From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success
Date: Mon, 23 May 2022 10:22:21 +0200 [thread overview]
Message-ID: <20220523082221.4qusbcylocpldf5u@pengutronix.de> (raw)
In-Reply-To: <7964f3ba-1c1c-af00-bbcb-12eb297716dc@pengutronix.de>
On 22-05-23, Ahmad Fatoum wrote:
> Hello Marco,
>
> On 23.05.22 10:00, Marco Felsch wrote:
> > Hi Ahmad,
> >
> > On 22-05-23, Ahmad Fatoum wrote:
> >> A successful probe results in two lines logged:
> >>
> >> usb251xb usb2514b0: Hub configuration was successful.
> >
> > The configuration (and this line) can be skipped if you specify
> > "skip-config".
> >
> >> usb251xb usb2514b0: Hub probed successfully
> >>
> >> There is no case where the first line is printed, but not the other and
> >> they say about the same thing anyway, so drop the latter.
> >
> > The config step can fail. What about lower down the log level for the
> > config step to dev_dbg() instead?
>
> If the config step fails we will get an error message from driver core.
> A driver with skip-config doesn't do anything useful that warrants
> a probed successfully message, so I think it's safe to drop it.
Hm.. with skip-config the driver still brings the hub out of reset and
into a working state. Anyway just wanted to pointed out, that there are
use-cases where the message is not printed twice.
Regards,
Marco
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-05-23 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 7:21 Ahmad Fatoum
2022-05-23 8:00 ` Marco Felsch
2022-05-23 8:11 ` Ahmad Fatoum
2022-05-23 8:22 ` Marco Felsch [this message]
2022-05-23 9:30 ` Ahmad Fatoum
2022-05-23 10:11 ` Marco Felsch
2022-05-24 4:47 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523082221.4qusbcylocpldf5u@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox