From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/8] serial: imx: add $global.bootm.earlycon fixup support
Date: Mon, 23 May 2022 13:04:05 +0200 [thread overview]
Message-ID: <20220523110405.GN25578@pengutronix.de> (raw)
In-Reply-To: <20220523092526.791716-5-a.fatoum@pengutronix.de>
On Mon, May 23, 2022 at 11:25:23AM +0200, Ahmad Fatoum wrote:
> Allow barebox compute a suitable earlycon parameter.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/serial/serial_imx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/serial/serial_imx.c b/drivers/serial/serial_imx.c
> index 6a933c930e9b..cf9c3f02a7ef 100644
> --- a/drivers/serial/serial_imx.c
> +++ b/drivers/serial/serial_imx.c
> @@ -234,6 +234,8 @@ static int imx_serial_probe(struct device_d *dev)
> cdev->flush = imx_serial_flush;
> cdev->setbrg = imx_serial_setbaudrate;
> cdev->linux_console_name = "ttymxc";
> + cdev->linux_earlycon_name = "ec_imx6q";
"ec_imx6q" sounds wrong for the older i.MX SoCs. I don't know how
OF_EARLYCON_DECLARE works, but this:
OF_EARLYCON_DECLARE(ec_imx6q, "fsl,imx6q-uart", imx_console_early_setup);
OF_EARLYCON_DECLARE(ec_imx21, "fsl,imx21-uart", imx_console_early_setup);
looks like it matches a device tree compatible entry. For the older SoCs
you should likely use "ec_imx21".
Anyway, plain "earlycon" just works, why the hassle?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-05-23 11:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 9:25 [PATCH 1/8] console: add new $global.bootm.earlycon parameter Ahmad Fatoum
2022-05-23 9:25 ` [PATCH 2/8] serial: ns16550: add $global.bootm.earlycon fixup support Ahmad Fatoum
2022-05-23 9:25 ` [PATCH 3/8] serial: amba-pl011: " Ahmad Fatoum
2022-05-23 9:25 ` [PATCH 4/8] serial: atmel: " Ahmad Fatoum
2022-05-23 9:25 ` [PATCH 5/8] serial: imx: " Ahmad Fatoum
2022-05-23 11:04 ` Sascha Hauer [this message]
2022-05-23 11:10 ` Ahmad Fatoum
2022-05-23 11:25 ` Sascha Hauer
2022-05-24 7:35 ` Ahmad Fatoum
2022-06-09 9:25 ` Sascha Hauer
2022-05-23 9:25 ` [PATCH 6/8] serial: litex: add linux console/earlycon " Ahmad Fatoum
2022-05-23 9:25 ` [PATCH 7/8] serial: lpuart: add $global.bootm.earlycon " Ahmad Fatoum
2022-05-23 9:25 ` [PATCH 8/8] video: efi_gop: add $global.bootm.earlycon fixup for framebuffer console Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523110405.GN25578@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox