From: Sascha Hauer <sha@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success
Date: Tue, 24 May 2022 06:47:23 +0200 [thread overview]
Message-ID: <20220524044723.GQ25578@pengutronix.de> (raw)
In-Reply-To: <20220523101106.l7njntapy7wlusrj@pengutronix.de>
On Mon, May 23, 2022 at 12:11:06PM +0200, Marco Felsch wrote:
> On 22-05-23, Ahmad Fatoum wrote:
> > On 23.05.22 10:22, Marco Felsch wrote:
> > > On 22-05-23, Ahmad Fatoum wrote:
> > >> Hello Marco,
> > >>
> > >> On 23.05.22 10:00, Marco Felsch wrote:
> > >>> Hi Ahmad,
> > >>>
> > >>> On 22-05-23, Ahmad Fatoum wrote:
> > >>>> A successful probe results in two lines logged:
> > >>>>
> > >>>> usb251xb usb2514b0: Hub configuration was successful.
> > >>>
> > >>> The configuration (and this line) can be skipped if you specify
> > >>> "skip-config".
> > >>>
> > >>>> usb251xb usb2514b0: Hub probed successfully
> > >>>>
> > >>>> There is no case where the first line is printed, but not the other and
> > >>>> they say about the same thing anyway, so drop the latter.
> > >>>
> > >>> The config step can fail. What about lower down the log level for the
> > >>> config step to dev_dbg() instead?
> > >>
> > >> If the config step fails we will get an error message from driver core.
> > >> A driver with skip-config doesn't do anything useful that warrants
> > >> a probed successfully message, so I think it's safe to drop it.
> > >
> > > Hm.. with skip-config the driver still brings the hub out of reset and
> > > into a working state. Anyway just wanted to pointed out, that there are
> > > use-cases where the message is not printed twice.
> >
> > Would you prefer I consolidate the logs messages into a single line instead?
>
> Still think that the easiest would be to lower the hub configuration
> print to dbg.
+1
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-05-24 4:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 7:21 Ahmad Fatoum
2022-05-23 8:00 ` Marco Felsch
2022-05-23 8:11 ` Ahmad Fatoum
2022-05-23 8:22 ` Marco Felsch
2022-05-23 9:30 ` Ahmad Fatoum
2022-05-23 10:11 ` Marco Felsch
2022-05-24 4:47 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524044723.GQ25578@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox