mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: DTS: myir-x335x: Add GPIO aliases
Date: Tue, 24 May 2022 11:03:14 +0200	[thread overview]
Message-ID: <20220524090314.sdb3tt6jhtjpmm6o@pengutronix.de> (raw)
In-Reply-To: <20220524073048.18467-1-eagle.alexander923@gmail.com>

On 22-05-24, Alexander Shiyan wrote:
> For the correct work of GPIO driver, we need to define aliases.
> Let's add them to the devicetree.
> 
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
>  arch/arm/dts/am335x-myirtech-myd.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/dts/am335x-myirtech-myd.dts b/arch/arm/dts/am335x-myirtech-myd.dts
> index 6ec65e533d..1ea0f2a440 100644
> --- a/arch/arm/dts/am335x-myirtech-myd.dts
> +++ b/arch/arm/dts/am335x-myirtech-myd.dts
> @@ -6,6 +6,13 @@
>  #include <arm/am335x-myirtech-myd.dts>
>  
>  / {
> +	aliases {
> +		gpio0 = &gpio0;
> +		gpio1 = &gpio1;
> +		gpio2 = &gpio2;
> +		gpio3 = &gpio3;
> +	};

Out of curiousity, are those aliases not defined in the "upstream" linux
device-tree? If not, wouldn't it be better to defined it there?

Regards,
  Marco

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-05-24  9:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24  7:30 Alexander Shiyan
2022-05-24  9:03 ` Marco Felsch [this message]
2022-05-24  9:21   ` Alexander Shiyan
2022-05-24 12:03     ` Marco Felsch
2022-05-24 12:28 ` Ahmad Fatoum
2022-05-25  6:23   ` Marco Felsch
2022-05-25  6:27   ` Alexander Shiyan
2022-05-25  8:16     ` Ahmad Fatoum
2022-05-25  8:33       ` Alexander Shiyan
2022-05-25  8:52         ` Ahmad Fatoum
2022-05-30  6:55 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220524090314.sdb3tt6jhtjpmm6o@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox