From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH RESEND] of: address: fix printing of OF node name in error message
Date: Tue, 7 Jun 2022 09:04:21 +0200 [thread overview]
Message-ID: <20220607070421.GJ1615@pengutronix.de> (raw)
In-Reply-To: <20220603072307.1578650-1-a.fatoum@pengutronix.de>
On Fri, Jun 03, 2022 at 09:23:07AM +0200, Ahmad Fatoum wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> barebox has no %pOF. Open code this instance to yield a better error
> message.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> RESEND: Decoupling from rpi4 series, no other changes
> ---
Applied, thanks
Sascha
> drivers/of/address.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 4eafce376d36..65e67973ad62 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -673,8 +673,8 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz
> dmaaddr = of_read_number(ranges, naddr);
> *paddr = of_translate_dma_address(node, ranges + naddr);
> if (*paddr == OF_BAD_ADDR) {
> - pr_err("translation of DMA address(%llx) to CPU address failed node(%pOF)\n",
> - dmaaddr, np);
> + pr_err("translation of DMA address(%llx) to CPU address failed node(%s)\n",
> + dmaaddr, np->name);
> ret = -EINVAL;
> goto out;
> }
> --
> 2.30.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-06-07 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 7:23 Ahmad Fatoum
2022-06-07 7:04 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607070421.GJ1615@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox