[PATCH RESEND] of: address: fix printing of OF node name in error message

[PATCH RESEND] of: address: fix printing of OF node name in error message

[Ahmad Fatoum]

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

barebox has no %pOF. Open code this instance to yield a better error
message.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> RESEND: Decoupling from rpi4 series, no other changes
---
 drivers/of/address.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/of/address.c b/drivers/of/address.c
index 4eafce376d36..65e67973ad62 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -673,8 +673,8 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz
 	dmaaddr = of_read_number(ranges, naddr);
 	*paddr = of_translate_dma_address(node, ranges + naddr);
 	if (*paddr == OF_BAD_ADDR) {
-		pr_err("translation of DMA address(%llx) to CPU address failed node(%pOF)\n",
-		       dmaaddr, np);
+		pr_err("translation of DMA address(%llx) to CPU address failed node(%s)\n",
+		       dmaaddr, np->name);
 		ret = -EINVAL;
 		goto out;
 	}
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH RESEND] of: address: fix printing of OF node name in error message

[Sascha Hauer]

On Fri, Jun 03, 2022 at 09:23:07AM +0200, Ahmad Fatoum wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> barebox has no %pOF. Open code this instance to yield a better error
> message.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> RESEND: Decoupling from rpi4 series, no other changes
> ---

Applied, thanks

Sascha

>  drivers/of/address.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 4eafce376d36..65e67973ad62 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -673,8 +673,8 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz
>  	dmaaddr = of_read_number(ranges, naddr);
>  	*paddr = of_translate_dma_address(node, ranges + naddr);
>  	if (*paddr == OF_BAD_ADDR) {
> -		pr_err("translation of DMA address(%llx) to CPU address failed node(%pOF)\n",
> -		       dmaaddr, np);
> +		pr_err("translation of DMA address(%llx) to CPU address failed node(%s)\n",
> +		       dmaaddr, np->name);
>  		ret = -EINVAL;
>  		goto out;
>  	}
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox