[PATCH v2 2/2] fastboot: inform user if barebox update falls back to raw copy

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Fastboot will fall back to a raw copy even for bbu- partitions if
no barebox_update was found or if support isn't compiled in.

Coupled with eMMC boot partitions, this could lead to
`barebox_update -t mmc` updating the boot partition, while a
`fastboot flash bbu-mmc` will write the image to the user area instead.

It's worth telling the user when this happens, so add a status message.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - print message in case barebox_update handler is not found
---
 common/fastboot.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/common/fastboot.c b/common/fastboot.c
index 330a06f5a32f..24eddf1cc3a5 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -683,8 +683,14 @@ static void cb_flash(struct fastboot *fb, const char *cmd)
 		};
 
 		handler = bbu_find_handler_by_device(data.devicefile);
-		if (!handler)
+		if (!handler) {
+			fastboot_tx_print(fb, FASTBOOT_MSG_INFO,
+					  "No suitable barebox_update handler found");
+			fastboot_tx_print(fb, FASTBOOT_MSG_INFO,
+					  "Falling back to raw copy to %s", filename);
+
 			goto copy;
+		}
 
 		fastboot_tx_print(fb, FASTBOOT_MSG_INFO,
 				  "This is a barebox image...");
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox