From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 09 Jun 2022 13:49:33 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzGfN-008igx-St for lore@lore.pengutronix.de; Thu, 09 Jun 2022 13:49:33 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzGfL-0006nb-IT for lore@pengutronix.de; Thu, 09 Jun 2022 13:49:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=N3TqEXyIUNhJjmAxhfEJfWBm+WoTpX5h0s5aGwAQehY=; b=gd3eha00wFTQ84M+ReS9bruw1J MVYLMyDs/gXZ4ehzkTTNx2W8JG8POU+e72XxxDni0ODxrcaDe463qDOnoObrjzp/mxOZnIpNKsA/t fJSFaUo1n2O8GaXdAN5KCL6ZWEcSE1IqL7MqMucBs5bYlersKas8dR4+ZL2wrOLH8ilj2D+3DiIwo g01RzzGjijkUqQayjwpyAQYfmTSw7GMZphhVbXybR5tZr2p2l6Y2HZqEPNpZgdg+Kxd9inzejJhXY VG5q2rk8d40ybSr7sae8/JVmBdSMCD/z0FlH8MLJfXj+N6/fHoHyEsn+Pd9dKZ9YG50WGCBBm7so9 ReYeb0Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzGdg-001SpY-9Q; Thu, 09 Jun 2022 11:47:48 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzGWB-001P4Z-Cq for barebox@lists.infradead.org; Thu, 09 Jun 2022 11:40:05 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzGW9-0004ii-Ro; Thu, 09 Jun 2022 13:40:01 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nzGW9-0004WT-Ih; Thu, 09 Jun 2022 13:40:01 +0200 Date: Thu, 9 Jun 2022 13:40:01 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20220609114001.GR1615@pengutronix.de> References: <20220609111703.2446899-1-a.fatoum@pengutronix.de> <20220609111703.2446899-2-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220609111703.2446899-2-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_044003_475281_80893622 X-CRM114-Status: GOOD ( 28.29 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 2/2] fastboot: inform user if barebox update falls back to raw copy X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Thu, Jun 09, 2022 at 01:17:03PM +0200, Ahmad Fatoum wrote: > Fastboot will fall back to a raw copy even for bbu- partitions if > no barebox_update was found or if support isn't compiled in. > > Coupled with eMMC boot partitions, this could lead to > `barebox_update -t mmc` updating the boot partition, while a > `fastboot flash bbu-mmc` will write the image to the user area instead. Have you seen this happen? > > It's worth telling the user when this happens, so add a status message. when a eMMC boot partition is registered for barebox update then the update should really go there. When it goes into the user area instead it's a bug. We shouldn't issue a warning then but deny the update and fix the underlying bug. Sascha > > Signed-off-by: Ahmad Fatoum > --- > v1 -> v2: > - print message in case barebox_update handler is not found > --- > common/fastboot.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/common/fastboot.c b/common/fastboot.c > index 330a06f5a32f..24eddf1cc3a5 100644 > --- a/common/fastboot.c > +++ b/common/fastboot.c > @@ -683,8 +683,14 @@ static void cb_flash(struct fastboot *fb, const char *cmd) > }; > > handler = bbu_find_handler_by_device(data.devicefile); > - if (!handler) > + if (!handler) { > + fastboot_tx_print(fb, FASTBOOT_MSG_INFO, > + "No suitable barebox_update handler found"); > + fastboot_tx_print(fb, FASTBOOT_MSG_INFO, > + "Falling back to raw copy to %s", filename); > + > goto copy; > + } > > fastboot_tx_print(fb, FASTBOOT_MSG_INFO, > "This is a barebox image..."); > -- > 2.30.2 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox