From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/3] nvmem: rmem: get, don't request, memory region
Date: Fri, 10 Jun 2022 10:13:31 +0200 [thread overview]
Message-ID: <20220610081331.GH1615@pengutronix.de> (raw)
In-Reply-To: <20220609111810.2454588-1-a.fatoum@pengutronix.de>
On Thu, Jun 09, 2022 at 01:18:08PM +0200, Ahmad Fatoum wrote:
> nvmem-rmem is a compatible for reserved memory entries, so the driver
> can't expect exclusive access to this region.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
> - no change
> ---
> drivers/nvmem/rmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/nvmem/rmem.c b/drivers/nvmem/rmem.c
> index cd735e5ef39d..b9331f48ffac 100644
> --- a/drivers/nvmem/rmem.c
> +++ b/drivers/nvmem/rmem.c
> @@ -31,7 +31,7 @@ static int rmem_probe(struct device_d *dev)
> struct resource *mem;
> struct rmem *priv;
>
> - mem = dev_request_mem_resource(dev, 0);
> + mem = dev_get_resource(dev, IORESOURCE_MEM, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
> --
> 2.30.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-06-10 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 11:18 Ahmad Fatoum
2022-06-09 11:18 ` [PATCH v2 2/3] of: remove unused and misleading #cells in /memreserve Ahmad Fatoum
2022-06-09 11:18 ` [PATCH v2 3/3] of: request reserved memory regions so other code can't Ahmad Fatoum
2022-06-15 5:08 ` Sascha Hauer
2022-06-15 6:06 ` Ahmad Fatoum
2022-06-15 6:28 ` Sascha Hauer
2022-06-10 8:13 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610081331.GH1615@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox