[PATCH 1/2] ARM: i.MX8MM: fix phy-reset gpio

[PATCH 1/2] ARM: i.MX8MM: fix phy-reset gpio

[Marco Felsch]

Drop the Barebox local property since the upstream/linux device-tree is
handling it now within the phy and we get an error:

   ERROR: gpiolib: _gpio_request: gpio-118 (ethernet-phy@0) status -16
   ERROR: miibus0: failed to request reset gpio for: ethernet-phy@0

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 arch/arm/dts/imx8mm-evk.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/dts/imx8mm-evk.dts b/arch/arm/dts/imx8mm-evk.dts
index 304f150307..854e9db869 100644
--- a/arch/arm/dts/imx8mm-evk.dts
+++ b/arch/arm/dts/imx8mm-evk.dts
@@ -24,10 +24,6 @@
 	};
 };
 
-&fec1 {
-	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
-};
-
 &usdhc2 {
 	#address-cells = <1>;
 	#size-cells = <1>;
-- 
2.30.2

[PATCH 2/2] ARM: i.MX8MM: increase off-on delay on the SD Vcc regulator

[Marco Felsch]

This commit is ported from u-boot commit 247bbeb74c ("ARM: dts: imx8m:
increase off-on delay on the SD Vcc regulator"). Currently barebox
supports only SDR25/HS mode but it gets important as soon as barebox
supports faster modes.

8<---------------------------------------------------------------------
    ARM: dts: imx8m: increase off-on delay on the SD Vcc regulator

    Some SD Card controller and power circuitry has increased capacitance,
    which keeps the internal logic remains powered after regulator is switch
    off. This is generally the case when card is switched to SD104 mode,
    where a power cycle should be performed. In case if the card internal
    logic remains powered, it causes a subsequent failure of mode
    transition, effectively leading to failed enumeration.

    Introduce a delay of 20 msec in order to provide a possibility for
    internal card circuitry to drain voltages and perform a power cycle
    correctly.

    Similar fix is done in commit c49d0ac38a76 ("ARM: dts: rmobile: Increase
    off-on delay on the SD Vcc regulator") targeted Renesas SOCs.

    Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
    Cc: Stefano Babic <sbabic@denx.de>
8<---------------------------------------------------------------------

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 arch/arm/dts/imx8mm-evk.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/imx8mm-evk.dts b/arch/arm/dts/imx8mm-evk.dts
index 854e9db869..6c06ad7e47 100644
--- a/arch/arm/dts/imx8mm-evk.dts
+++ b/arch/arm/dts/imx8mm-evk.dts
@@ -24,6 +24,10 @@
 	};
 };
 
+&reg_usdhc2_vmmc {
+	off-on-delay-us = <20000>;
+};
+
 &usdhc2 {
 	#address-cells = <1>;
 	#size-cells = <1>;
-- 
2.30.2

Re: [PATCH 1/2] ARM: i.MX8MM: fix phy-reset gpio

[Sascha Hauer]

On Thu, Jun 16, 2022 at 04:02:45PM +0200, Marco Felsch wrote:
> Drop the Barebox local property since the upstream/linux device-tree is
> handling it now within the phy and we get an error:
> 
>    ERROR: gpiolib: _gpio_request: gpio-118 (ethernet-phy@0) status -16
>    ERROR: miibus0: failed to request reset gpio for: ethernet-phy@0
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  arch/arm/dts/imx8mm-evk.dts | 4 ----
>  1 file changed, 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/dts/imx8mm-evk.dts b/arch/arm/dts/imx8mm-evk.dts
> index 304f150307..854e9db869 100644
> --- a/arch/arm/dts/imx8mm-evk.dts
> +++ b/arch/arm/dts/imx8mm-evk.dts
> @@ -24,10 +24,6 @@
>  	};
>  };
>  
> -&fec1 {
> -	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> -};
> -
>  &usdhc2 {
>  	#address-cells = <1>;
>  	#size-cells = <1>;
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |