* [PATCH] driver: probe: report power domain attach failure
@ 2022-07-30 9:49 Ahmad Fatoum
2022-08-08 13:12 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-07-30 9:49 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Power domains are attached before driver probe and non-existence of
power domain driver leads to permanent probe deferral without any
pointer as to why. Add a status message to make debugging easier.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/base/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 2fb73917b43c..c0ea2746b388 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -17,7 +17,7 @@ static int platform_probe(struct device_d *dev)
ret = genpd_dev_pm_attach(dev);
if (ret < 0)
- return ret;
+ return dev_err_probe(dev, ret, "power domain attach failed\n");
return dev->driver->probe(dev);
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] driver: probe: report power domain attach failure
2022-07-30 9:49 [PATCH] driver: probe: report power domain attach failure Ahmad Fatoum
@ 2022-08-08 13:12 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-08-08 13:12 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Sat, Jul 30, 2022 at 11:49:55AM +0200, Ahmad Fatoum wrote:
> Power domains are attached before driver probe and non-existence of
> power domain driver leads to permanent probe deferral without any
> pointer as to why. Add a status message to make debugging easier.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/base/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 2fb73917b43c..c0ea2746b388 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -17,7 +17,7 @@ static int platform_probe(struct device_d *dev)
>
> ret = genpd_dev_pm_attach(dev);
> if (ret < 0)
> - return ret;
> + return dev_err_probe(dev, ret, "power domain attach failed\n");
>
> return dev->driver->probe(dev);
> }
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-08 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-30 9:49 [PATCH] driver: probe: report power domain attach failure Ahmad Fatoum
2022-08-08 13:12 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox