Re: [PATCH 0/8] tftp fixups

[Sascha Hauer <sha@pengutronix.de>]

On Mon, Aug 29, 2022 at 12:52:16PM +0200, Ahmad Fatoum wrote:
> Hello Enrico,
> 
> On 28.08.22 16:02, Enrico Scholz wrote:
> > The "tftp: allocate buffers and fifo dynamically" patch in the last
> > patchset broke interaction with non rfc 2347 servers (e.g. when data
> > transfer starts immediately after RRQ/WRQ without the OACK negotiation
> > phase).
> > 
> > This has been fixed for both RRQ and WRQ requests.
> > 
> > For WRQ requests (push), the "tsize" option will not be sent anymore
> > because it is always '0' and can confuse servers.
> > 
> > New patches add some sanity checks which prevent modification of
> > internal information (blocksize or port numbers) when OACK packets
> > arrive in the middle of a transfer.
> 
> The patch introducing the regression is still in next, which can be
> rebased unlike master. Perhaps it would be best you provide a fixup
> for the commit in question (or a revised series, if it would cause
> conflicts for later commits)? That way, we don't end up with breakage
> when doing a bisect in future.

Yes, please. Both a fixup patch or a revised series would be fine with
me.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |