mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] test: emulate.pl: fix support for multiple block devices
@ 2022-10-10  6:05 Ahmad Fatoum
  2022-10-10  6:16 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-10-10  6:05 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Block devices on QEMU command line need a unique id. The id factors in
$i, which we failed to increment.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 test/emulate.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/emulate.pl b/test/emulate.pl
index 77b751a329b3..b5e2188b86dd 100755
--- a/test/emulate.pl
+++ b/test/emulate.pl
@@ -253,6 +253,8 @@ sub emulate {
 		} else {
 		    die "--blk unsupported for target\n";
 		}
+
+		$i++;
 	    }
 
 	    # note that barebox doesn't yet support multiple virtio consoles
-- 
2.30.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] test: emulate.pl: fix support for multiple block devices
  2022-10-10  6:05 [PATCH master] test: emulate.pl: fix support for multiple block devices Ahmad Fatoum
@ 2022-10-10  6:16 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-10-10  6:16 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Mon, Oct 10, 2022 at 08:05:04AM +0200, Ahmad Fatoum wrote:
> Block devices on QEMU command line need a unique id. The id factors in
> $i, which we failed to increment.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  test/emulate.pl | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/test/emulate.pl b/test/emulate.pl
> index 77b751a329b3..b5e2188b86dd 100755
> --- a/test/emulate.pl
> +++ b/test/emulate.pl
> @@ -253,6 +253,8 @@ sub emulate {
>  		} else {
>  		    die "--blk unsupported for target\n";
>  		}
> +
> +		$i++;
>  	    }
>  
>  	    # note that barebox doesn't yet support multiple virtio consoles
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-10  6:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10  6:05 [PATCH master] test: emulate.pl: fix support for multiple block devices Ahmad Fatoum
2022-10-10  6:16 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox