[PATCH] mfd: axp20x: drop info message on successful probe

[PATCH] mfd: axp20x: drop info message on successful probe

[Ahmad Fatoum]

Successful probe is expected and doesn't warrant a message. The driver
will already print that what variant in that case. In the error case,
we will get an error message anyway, so this log message serves no
purpose.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mfd/axp20x.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 0a53eaea7cfa..8d9de59e7d49 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -354,8 +354,6 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
 	if (axp20x->variant != AXP288_ID)
 		poweroff_handler_register(&axp20x->poweroff);
 
-	dev_info(axp20x->dev, "AXP20X driver loaded\n");
-
 	return 0;
 }
 EXPORT_SYMBOL(axp20x_device_probe);
-- 
2.30.2

Re: [PATCH] mfd: axp20x: drop info message on successful probe

[Sascha Hauer]

On Mon, Oct 17, 2022 at 09:05:17AM +0200, Ahmad Fatoum wrote:
> Successful probe is expected and doesn't warrant a message. The driver
> will already print that what variant in that case. In the error case,
> we will get an error message anyway, so this log message serves no
> purpose.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/mfd/axp20x.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 0a53eaea7cfa..8d9de59e7d49 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -354,8 +354,6 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>  	if (axp20x->variant != AXP288_ID)
>  		poweroff_handler_register(&axp20x->poweroff);
>  
> -	dev_info(axp20x->dev, "AXP20X driver loaded\n");
> -
>  	return 0;
>  }
>  EXPORT_SYMBOL(axp20x_device_probe);
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |