From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mfd: axp20x: drop info message on successful probe
Date: Tue, 18 Oct 2022 11:17:48 +0200 [thread overview]
Message-ID: <20221018091748.GT6702@pengutronix.de> (raw)
In-Reply-To: <20221017070517.1456378-1-a.fatoum@pengutronix.de>
On Mon, Oct 17, 2022 at 09:05:17AM +0200, Ahmad Fatoum wrote:
> Successful probe is expected and doesn't warrant a message. The driver
> will already print that what variant in that case. In the error case,
> we will get an error message anyway, so this log message serves no
> purpose.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/mfd/axp20x.c | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 0a53eaea7cfa..8d9de59e7d49 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -354,8 +354,6 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
> if (axp20x->variant != AXP288_ID)
> poweroff_handler_register(&axp20x->poweroff);
>
> - dev_info(axp20x->dev, "AXP20X driver loaded\n");
> -
> return 0;
> }
> EXPORT_SYMBOL(axp20x_device_probe);
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2022-10-18 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 7:05 Ahmad Fatoum
2022-10-18 9:17 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018091748.GT6702@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox