* i.MX watchdog druver regression
@ 2022-10-21 9:53 Alexander Shiyan
2022-10-21 11:43 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Shiyan @ 2022-10-21 9:53 UTC (permalink / raw)
To: Barebox List
Hello!
An error occurred while registering the i.MX watchdog driver:
barebox 2022.06.0-00530-g31d9ff81c63c-dirty #44 Fri Oct 21 12:13:36 MSK 2022
...
ERROR: imx-watchdog 73f98000.watchdog@73f98000.of: probe failed: No
such file or directory
...
Thought it was the result of a patch "watchdog: imxwd: get and enable clock",
and added the line:
clks[IMX5_CLK_DUMMY] = clk_fixed("dummy", 0);
into the beginning of the mx5_clocks_common_init() function, but this
does not help...
Does anyone have any ideas about this?
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: i.MX watchdog druver regression 2022-10-21 9:53 i.MX watchdog druver regression Alexander Shiyan @ 2022-10-21 11:43 ` Sascha Hauer 2022-10-21 11:47 ` Ahmad Fatoum 0 siblings, 1 reply; 4+ messages in thread From: Sascha Hauer @ 2022-10-21 11:43 UTC (permalink / raw) To: Alexander Shiyan; +Cc: Barebox List On Fri, Oct 21, 2022 at 12:53:59PM +0300, Alexander Shiyan wrote: > Hello! > > An error occurred while registering the i.MX watchdog driver: > > barebox 2022.06.0-00530-g31d9ff81c63c-dirty #44 Fri Oct 21 12:13:36 MSK 2022 > ... > ERROR: imx-watchdog 73f98000.watchdog@73f98000.of: probe failed: No > such file or directory > ... > > Thought it was the result of a patch "watchdog: imxwd: get and enable clock", > and added the line: > clks[IMX5_CLK_DUMMY] = clk_fixed("dummy", 0); > into the beginning of the mx5_clocks_common_init() function, but this > does not help... If the missing clock is the problem then you also have to tell the clock core that the dummy clock shall be provided to the watchdog, something like: clkdev_add_physbase(clks[IMX5_CLK_DUMMY], MX53_WDOG1_BASE_ADDR, NULL); clkdev_add_physbase(clks[IMX5_CLK_DUMMY], MX53_WDOG2_BASE_ADDR, NULL); similar is missing for i.MX51 as well Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: i.MX watchdog druver regression 2022-10-21 11:43 ` Sascha Hauer @ 2022-10-21 11:47 ` Ahmad Fatoum 2022-10-21 11:56 ` Sascha Hauer 0 siblings, 1 reply; 4+ messages in thread From: Ahmad Fatoum @ 2022-10-21 11:47 UTC (permalink / raw) To: Sascha Hauer, Alexander Shiyan; +Cc: Barebox List On 21.10.22 13:43, Sascha Hauer wrote: > On Fri, Oct 21, 2022 at 12:53:59PM +0300, Alexander Shiyan wrote: >> Hello! >> >> An error occurred while registering the i.MX watchdog driver: >> >> barebox 2022.06.0-00530-g31d9ff81c63c-dirty #44 Fri Oct 21 12:13:36 MSK 2022 >> ... >> ERROR: imx-watchdog 73f98000.watchdog@73f98000.of: probe failed: No >> such file or directory >> ... >> >> Thought it was the result of a patch "watchdog: imxwd: get and enable clock", >> and added the line: >> clks[IMX5_CLK_DUMMY] = clk_fixed("dummy", 0); >> into the beginning of the mx5_clocks_common_init() function, but this >> does not help... > > If the missing clock is the problem then you also have to tell the clock > core that the dummy clock shall be provided to the watchdog, something > like: > > clkdev_add_physbase(clks[IMX5_CLK_DUMMY], MX53_WDOG1_BASE_ADDR, NULL); > clkdev_add_physbase(clks[IMX5_CLK_DUMMY], MX53_WDOG2_BASE_ADDR, NULL); > > similar is missing for i.MX51 as well But the imx50.dtsi device tree already has clocks = <&clks IMX5_CLK_DUMMY>; > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: i.MX watchdog druver regression 2022-10-21 11:47 ` Ahmad Fatoum @ 2022-10-21 11:56 ` Sascha Hauer 0 siblings, 0 replies; 4+ messages in thread From: Sascha Hauer @ 2022-10-21 11:56 UTC (permalink / raw) To: Ahmad Fatoum; +Cc: Alexander Shiyan, Barebox List On Fri, Oct 21, 2022 at 01:47:35PM +0200, Ahmad Fatoum wrote: > On 21.10.22 13:43, Sascha Hauer wrote: > > On Fri, Oct 21, 2022 at 12:53:59PM +0300, Alexander Shiyan wrote: > >> Hello! > >> > >> An error occurred while registering the i.MX watchdog driver: > >> > >> barebox 2022.06.0-00530-g31d9ff81c63c-dirty #44 Fri Oct 21 12:13:36 MSK 2022 > >> ... > >> ERROR: imx-watchdog 73f98000.watchdog@73f98000.of: probe failed: No > >> such file or directory > >> ... > >> > >> Thought it was the result of a patch "watchdog: imxwd: get and enable clock", > >> and added the line: > >> clks[IMX5_CLK_DUMMY] = clk_fixed("dummy", 0); > >> into the beginning of the mx5_clocks_common_init() function, but this > >> does not help... > > > > If the missing clock is the problem then you also have to tell the clock > > core that the dummy clock shall be provided to the watchdog, something > > like: > > > > clkdev_add_physbase(clks[IMX5_CLK_DUMMY], MX53_WDOG1_BASE_ADDR, NULL); > > clkdev_add_physbase(clks[IMX5_CLK_DUMMY], MX53_WDOG2_BASE_ADDR, NULL); > > > > similar is missing for i.MX51 as well > > But the imx50.dtsi device tree already has > > clocks = <&clks IMX5_CLK_DUMMY>; I thought the device tree clocks are unused, because otherwise we could remove the clkdev_add_physbase() calls. Ok, these are there for the remaining non device tree boards. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-21 11:57 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-10-21 9:53 i.MX watchdog druver regression Alexander Shiyan 2022-10-21 11:43 ` Sascha Hauer 2022-10-21 11:47 ` Ahmad Fatoum 2022-10-21 11:56 ` Sascha Hauer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox