mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] reset: add missing stub for of_reset_control_get()
@ 2022-10-31  7:34 Denis Orlov
  2022-11-01  9:00 ` Ahmad Fatoum
  2022-11-02  7:35 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Denis Orlov @ 2022-10-31  7:34 UTC (permalink / raw)
  To: barebox; +Cc: Denis Orlov

Every other function in reset.h has a corresponding stub that is used
when the option RESET_CONTROLLER is disabled in config. This allows for
code that uses this function to still be compilable even when the reset
controller subsystem is disabled.

Signed-off-by: Denis Orlov <denorl2009@gmail.com>
---
 include/linux/reset.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/reset.h b/include/linux/reset.h
index c1282a84c7..2d788547f4 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -48,6 +48,12 @@ static inline int reset_control_deassert(struct reset_control *rstc)
 	return 0;
 }
 
+static inline struct reset_control *
+of_reset_control_get(struct device_node *node, const char *id)
+{
+	return NULL;
+}
+
 static inline struct reset_control *
 reset_control_get(struct device_d *dev, const char *id)
 {
-- 
2.30.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] reset: add missing stub for of_reset_control_get()
  2022-10-31  7:34 [PATCH] reset: add missing stub for of_reset_control_get() Denis Orlov
@ 2022-11-01  9:00 ` Ahmad Fatoum
  2022-11-02  7:35 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2022-11-01  9:00 UTC (permalink / raw)
  To: Denis Orlov, barebox

On 31.10.22 08:34, Denis Orlov wrote:
> Every other function in reset.h has a corresponding stub that is used
> when the option RESET_CONTROLLER is disabled in config. This allows for
> code that uses this function to still be compilable even when the reset
> controller subsystem is disabled.
> 
> Signed-off-by: Denis Orlov <denorl2009@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  include/linux/reset.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index c1282a84c7..2d788547f4 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -48,6 +48,12 @@ static inline int reset_control_deassert(struct reset_control *rstc)
>  	return 0;
>  }
>  
> +static inline struct reset_control *
> +of_reset_control_get(struct device_node *node, const char *id)
> +{
> +	return NULL;
> +}
> +
>  static inline struct reset_control *
>  reset_control_get(struct device_d *dev, const char *id)
>  {

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] reset: add missing stub for of_reset_control_get()
  2022-10-31  7:34 [PATCH] reset: add missing stub for of_reset_control_get() Denis Orlov
  2022-11-01  9:00 ` Ahmad Fatoum
@ 2022-11-02  7:35 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2022-11-02  7:35 UTC (permalink / raw)
  To: Denis Orlov; +Cc: barebox

On Mon, Oct 31, 2022 at 10:34:29AM +0300, Denis Orlov wrote:
> Every other function in reset.h has a corresponding stub that is used
> when the option RESET_CONTROLLER is disabled in config. This allows for
> code that uses this function to still be compilable even when the reset
> controller subsystem is disabled.
> 
> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
> ---
>  include/linux/reset.h | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index c1282a84c7..2d788547f4 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -48,6 +48,12 @@ static inline int reset_control_deassert(struct reset_control *rstc)
>  	return 0;
>  }
>  
> +static inline struct reset_control *
> +of_reset_control_get(struct device_node *node, const char *id)
> +{
> +	return NULL;
> +}
> +
>  static inline struct reset_control *
>  reset_control_get(struct device_d *dev, const char *id)
>  {
> -- 
> 2.30.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-02  7:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-31  7:34 [PATCH] reset: add missing stub for of_reset_control_get() Denis Orlov
2022-11-01  9:00 ` Ahmad Fatoum
2022-11-02  7:35 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox