mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 3/4] ARM: zii-imx8mq-dev: include DDR firmware in image
Date: Wed,  7 Dec 2022 23:09:23 +0100	[thread overview]
Message-ID: <20221207220924.148327-3-l.stach@pengutronix.de> (raw)
In-Reply-To: <20221207220924.148327-1-l.stach@pengutronix.de>

This board uses the legacy DRAM initialization and doesn't call
imx8mq_ddr_init(), so there is no point where the DRAM firmware is
referenced from the image. Fix this by calling ddr_get_firmware()
from the legacy DRAM init.

Fixes: e770d18108de ("ARM: i.MX8M: include only necessary ddrphy firmwares in image")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/boards/zii-imx8mq-dev/ddrphy_train.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boards/zii-imx8mq-dev/ddrphy_train.c b/arch/arm/boards/zii-imx8mq-dev/ddrphy_train.c
index d2c73fc7ce22..e8577369dc8b 100644
--- a/arch/arm/boards/zii-imx8mq-dev/ddrphy_train.c
+++ b/arch/arm/boards/zii-imx8mq-dev/ddrphy_train.c
@@ -11,6 +11,8 @@
 void ddr_cfg_phy(void) {
 	unsigned int tmp, tmp_t;
 
+	ddr_get_firmware(DRAM_TYPE_LPDDR4);
+
 	//Init DDRPHY register...
 	reg32_write(0x3c080440,0x2);
 	reg32_write(0x3c080444,0x3);
-- 
2.38.1




  parent reply	other threads:[~2022-12-07 22:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 22:09 [PATCH 1/4] ARM: imx8m: allow ddr_get_firmware to be called from other units Lucas Stach
2022-12-07 22:09 ` [PATCH 2/4] ARM: nxp-imx8mq-evk: include DDR firmware in image Lucas Stach
2022-12-07 22:09 ` Lucas Stach [this message]
2022-12-07 22:09 ` [PATCH 4/4] ARM: phytec-som-imx8mq: " Lucas Stach
2022-12-09  7:14 ` [PATCH 1/4] ARM: imx8m: allow ddr_get_firmware to be called from other units Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221207220924.148327-3-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox