[PATCH v2] ARM: dts: fix wrong display-timings native-mode binding

[PATCH v2] ARM: dts: fix wrong display-timings native-mode binding

[Ahmad Fatoum]

The value of the native-mode property is supposed to be a phandle to
the entry in question, but instead the full node path was used because
the <angle brackets> were missing. Fix this. This should not involve any
functional change as the default mode would've been the first element,
which is the same element the malformed native-mode was meant to point
at anyway.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/dts/imx6q-var-custom.dts   | 2 +-
 arch/arm/dts/imx6qdl-skov-imx6.dtsi | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/imx6q-var-custom.dts b/arch/arm/dts/imx6q-var-custom.dts
index ddb220fb0ad4..cbfe4da7e1b4 100644
--- a/arch/arm/dts/imx6q-var-custom.dts
+++ b/arch/arm/dts/imx6q-var-custom.dts
@@ -83,7 +83,7 @@
 		fsl,data-width = <24>;
 		status = "okay";
 		display-timings {
-			native-mode = &claawvga;
+			native-mode = <&claawvga>;
 			claawvga: claawvga {
 				native-mode;
 				clock-frequency = <35714000>;
diff --git a/arch/arm/dts/imx6qdl-skov-imx6.dtsi b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
index f4610ee1e7ba..cb4224f1b441 100644
--- a/arch/arm/dts/imx6qdl-skov-imx6.dtsi
+++ b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
@@ -146,7 +146,7 @@
 		};
 
 		display-timings {
-			native-mode = &l2rt;
+			native-mode = <&l2rt>;
 
 			l2rt: l2rt {
 				native-mode;
@@ -190,7 +190,7 @@
 		/* power-supply = <&reg_3p3v>; */
 
 		display-timings {
-			native-mode = &mi1010ait_1cp1;
+			native-mode = <&mi1010ait_1cp1>;
 
 			mi1010ait_1cp1: mi1010ait-1cp1 {
 				native-mode;
-- 
2.30.2

Re: [PATCH v2] ARM: dts: fix wrong display-timings native-mode binding

[Sam Ravnborg]

On Wed, Dec 21, 2022 at 11:26:27AM +0100, Ahmad Fatoum wrote:
> The value of the native-mode property is supposed to be a phandle to
> the entry in question, but instead the full node path was used because
> the <angle brackets> were missing. Fix this. This should not involve any
> functional change as the default mode would've been the first element,
> which is the same element the malformed native-mode was meant to point
> at anyway.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

	Sam

Re: [PATCH v2] ARM: dts: fix wrong display-timings native-mode binding

[Sascha Hauer]

On Wed, Dec 21, 2022 at 11:26:27AM +0100, Ahmad Fatoum wrote:
> The value of the native-mode property is supposed to be a phandle to
> the entry in question, but instead the full node path was used because
> the <angle brackets> were missing. Fix this. This should not involve any
> functional change as the default mode would've been the first element,
> which is the same element the malformed native-mode was meant to point
> at anyway.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/dts/imx6q-var-custom.dts   | 2 +-
>  arch/arm/dts/imx6qdl-skov-imx6.dtsi | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/dts/imx6q-var-custom.dts b/arch/arm/dts/imx6q-var-custom.dts
> index ddb220fb0ad4..cbfe4da7e1b4 100644
> --- a/arch/arm/dts/imx6q-var-custom.dts
> +++ b/arch/arm/dts/imx6q-var-custom.dts
> @@ -83,7 +83,7 @@
>  		fsl,data-width = <24>;
>  		status = "okay";
>  		display-timings {
> -			native-mode = &claawvga;
> +			native-mode = <&claawvga>;
>  			claawvga: claawvga {
>  				native-mode;
>  				clock-frequency = <35714000>;
> diff --git a/arch/arm/dts/imx6qdl-skov-imx6.dtsi b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
> index f4610ee1e7ba..cb4224f1b441 100644
> --- a/arch/arm/dts/imx6qdl-skov-imx6.dtsi
> +++ b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
> @@ -146,7 +146,7 @@
>  		};
>  
>  		display-timings {
> -			native-mode = &l2rt;
> +			native-mode = <&l2rt>;
>  
>  			l2rt: l2rt {
>  				native-mode;
> @@ -190,7 +190,7 @@
>  		/* power-supply = <&reg_3p3v>; */
>  
>  		display-timings {
> -			native-mode = &mi1010ait_1cp1;
> +			native-mode = <&mi1010ait_1cp1>;
>  
>  			mi1010ait_1cp1: mi1010ait-1cp1 {
>  				native-mode;
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |