mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] regulator: scmi: rename struct scmi_regulator::device_node to of_node
Date: Tue, 10 Jan 2023 15:55:27 +0100	[thread overview]
Message-ID: <20230110145527.GO28911@pengutronix.de> (raw)
In-Reply-To: <20230109151944.2070704-1-a.fatoum@pengutronix.de>

On Mon, Jan 09, 2023 at 04:19:44PM +0100, Ahmad Fatoum wrote:
> The naming is different than the Linux driver and was only chosen for
> symmetry with device_d::device_node. Now that this is renamed to
> device:of_node, follow suite in the barebox driver.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/regulator/scmi-regulator.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
> index 22813ce66248..2a007ac620a1 100644
> --- a/drivers/regulator/scmi-regulator.c
> +++ b/drivers/regulator/scmi-regulator.c
> @@ -44,7 +44,7 @@ struct scmi_regulator {
>  	struct scmi_device *sdev;
>  	struct scmi_protocol_handle *ph;
>  	struct regulator_dev rdev;
> -	struct device_node *device_node;
> +	struct device_node *of_node;
>  	struct scmi_reg_desc sdesc;
>  };
>  
> @@ -232,7 +232,7 @@ static int scmi_regulator_common_init(struct scmi_regulator *sreg)
>  	 */
>  	if (vinfo->negative_volts_allowed) {
>  		dev_warn(dev, "Negative voltages NOT supported...skip %s\n",
> -			 sreg->device_node->full_name);
> +			 sreg->of_node->full_name);
>  		return -EOPNOTSUPP;
>  	}
>  
> @@ -278,7 +278,7 @@ static int process_scmi_regulator_of_node(struct scmi_device *sdev,
>  	rinfo->sregv[dom]->ph = ph;
>  
>  	/* get hold of good nodes */
> -	rinfo->sregv[dom]->device_node = np;
> +	rinfo->sregv[dom]->of_node = np;
>  
>  	dev_dbg(&sdev->dev,
>  		"Found SCMI Regulator entry -- OF node [%d] -> %s\n",
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-01-10 14:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 15:19 Ahmad Fatoum
2023-01-10 14:55 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230110145527.GO28911@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox