* [PATCH] net: e1000: don't use nanosecond constants in readl_poll_timeout
@ 2023-01-10 17:27 Ahmad Fatoum
2023-01-11 9:13 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2023-01-10 17:27 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
The MSECOND/USECOND constants are in nanoseconds, while
readl_poll_timeout accepts microseconds. No functional change.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/net/e1000/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/e1000/main.c b/drivers/net/e1000/main.c
index 1f84cf2949fd..e00bc4841716 100644
--- a/drivers/net/e1000/main.c
+++ b/drivers/net/e1000/main.c
@@ -3476,7 +3476,7 @@ static int e1000_transmit(struct eth_device *edev, void *txpacket, int length)
ret = readl_poll_timeout(&txp->upper.data,
stat, stat & E1000_TXD_STAT_DD,
- MSECOND / USECOND);
+ USEC_PER_MSEC);
if (ret)
dev_dbg(hw->dev, "e1000: tx timeout\n");
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: e1000: don't use nanosecond constants in readl_poll_timeout
2023-01-10 17:27 [PATCH] net: e1000: don't use nanosecond constants in readl_poll_timeout Ahmad Fatoum
@ 2023-01-11 9:13 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2023-01-11 9:13 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Tue, Jan 10, 2023 at 06:27:20PM +0100, Ahmad Fatoum wrote:
> The MSECOND/USECOND constants are in nanoseconds, while
> readl_poll_timeout accepts microseconds. No functional change.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/net/e1000/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/e1000/main.c b/drivers/net/e1000/main.c
> index 1f84cf2949fd..e00bc4841716 100644
> --- a/drivers/net/e1000/main.c
> +++ b/drivers/net/e1000/main.c
> @@ -3476,7 +3476,7 @@ static int e1000_transmit(struct eth_device *edev, void *txpacket, int length)
>
> ret = readl_poll_timeout(&txp->upper.data,
> stat, stat & E1000_TXD_STAT_DD,
> - MSECOND / USECOND);
> + USEC_PER_MSEC);
> if (ret)
> dev_dbg(hw->dev, "e1000: tx timeout\n");
>
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-11 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 17:27 [PATCH] net: e1000: don't use nanosecond constants in readl_poll_timeout Ahmad Fatoum
2023-01-11 9:13 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox