Re: [PATCH] net: e1000: don't use nanosecond constants in readl_poll_timeout

[Sascha Hauer <sha@pengutronix.de>]

On Tue, Jan 10, 2023 at 06:27:20PM +0100, Ahmad Fatoum wrote:
> The MSECOND/USECOND constants are in nanoseconds, while
> readl_poll_timeout accepts microseconds. No functional change.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/net/e1000/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/e1000/main.c b/drivers/net/e1000/main.c
> index 1f84cf2949fd..e00bc4841716 100644
> --- a/drivers/net/e1000/main.c
> +++ b/drivers/net/e1000/main.c
> @@ -3476,7 +3476,7 @@ static int e1000_transmit(struct eth_device *edev, void *txpacket, int length)
>  
>  	ret = readl_poll_timeout(&txp->upper.data,
>  				 stat, stat & E1000_TXD_STAT_DD,
> -				 MSECOND / USECOND);
> +				 USEC_PER_MSEC);
>  	if (ret)
>  		dev_dbg(hw->dev, "e1000: tx timeout\n");
>  
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |