[PATCH] net: eth: skip opening disabled interfaces when going interactive

[PATCH] net: eth: skip opening disabled interfaces when going interactive

[Ahmad Fatoum]

Ethernet device global mode (ethX.mode) may be set to disabled when
ports should not be used. This setting is already respect in ifup, so do
likewise for eth_open_all(), which is called when going interactive.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 net/eth.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/eth.c b/net/eth.c
index 863d0a046657..6fb64afea024 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -535,8 +535,11 @@ void eth_open_all(void)
 {
 	struct eth_device *edev;
 
-	list_for_each_entry(edev, &netdev_list, list)
+	list_for_each_entry(edev, &netdev_list, list) {
+		if (edev->global_mode == ETH_MODE_DISABLED)
+			continue;
 		eth_open(edev);
+	}
 }
 
 static int of_populate_ethaddr(void)
-- 
2.30.2

Re: [PATCH] net: eth: skip opening disabled interfaces when going interactive

[Sascha Hauer]

On Tue, Jan 17, 2023 at 10:49:34AM +0100, Ahmad Fatoum wrote:
> Ethernet device global mode (ethX.mode) may be set to disabled when
> ports should not be used. This setting is already respect in ifup, so do
> likewise for eth_open_all(), which is called when going interactive.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  net/eth.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/net/eth.c b/net/eth.c
> index 863d0a046657..6fb64afea024 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -535,8 +535,11 @@ void eth_open_all(void)
>  {
>  	struct eth_device *edev;
>  
> -	list_for_each_entry(edev, &netdev_list, list)
> +	list_for_each_entry(edev, &netdev_list, list) {
> +		if (edev->global_mode == ETH_MODE_DISABLED)
> +			continue;
>  		eth_open(edev);
> +	}
>  }
>  
>  static int of_populate_ethaddr(void)
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |