From: Michael Grzeschik <m.grzeschik@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] phy: stm32-usphyc: add mdelay(1) to fix timeout on some machines
Date: Tue, 24 Jan 2023 21:31:19 +0100 [thread overview]
Message-ID: <20230124203119.3489559-1-m.grzeschik@pengutronix.de> (raw)
An mdelay of 1 seems to be necessary on some machines, since
the monsel status does not seem to be accurate. On rare occasions just
working with the phy after this pll check lead to no functional usb.
With this short mdelay this issue was not reported again.
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
drivers/phy/phy-stm32-usbphyc.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/phy/phy-stm32-usbphyc.c b/drivers/phy/phy-stm32-usbphyc.c
index 657824405f..aff6b60d5e 100644
--- a/drivers/phy/phy-stm32-usbphyc.c
+++ b/drivers/phy/phy-stm32-usbphyc.c
@@ -271,6 +271,15 @@ static int stm32_usbphyc_phy_init(struct phy *phy)
goto pll_disable;
}
+ /* This is a workaround that seems to be necessary on some
+ * machines, since the monsel status does not seem to be
+ * accurate. On rare occasions just working with the phy after
+ * this pll check the usb peripheral (e.g. on the dwc2) run into
+ * timeout issues and leading to no functional usb. With this
+ * short mdelay this issue was not reported again.
+ */
+ mdelay(1);
+
usbphyc_phy->active = true;
return 0;
--
2.30.2
next reply other threads:[~2023-01-24 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 20:31 Michael Grzeschik [this message]
2023-01-26 8:15 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124203119.3489559-1-m.grzeschik@pengutronix.de \
--to=m.grzeschik@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox