From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] i2c: implement detect callback for virtual adapter device as well
Date: Wed, 25 Jan 2023 08:53:23 +0100 [thread overview]
Message-ID: <20230125075323.1759934-1-a.fatoum@pengutronix.de> (raw)
For MMCs, we already support detect on both the hardware device and the
mmcX virtual device. Let's do the same for i2c, so users have the option
to do `detect i2c0` instead of `detect 30a30000.i2c@30a30000.of`.
`detect -a` still works as expected, as the detect callback is a no-op
if everything on the bus is already registered.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/i2c/i2c.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c.c b/drivers/i2c/i2c.c
index 7e1cea49f3b6..4ecf7bb163e6 100644
--- a/drivers/i2c/i2c.c
+++ b/drivers/i2c/i2c.c
@@ -472,6 +472,14 @@ int of_i2c_register_devices_by_node(struct device_node *node)
}
static int i2c_bus_detect(struct device *dev)
+{
+ struct i2c_adapter *adap = container_of(dev, struct i2c_adapter, dev);
+
+ of_i2c_register_devices(adap);
+ return 0;
+}
+
+static int i2c_hw_detect(struct device *dev)
{
struct i2c_adapter *adap;
@@ -712,6 +720,7 @@ int i2c_add_numbered_adapter(struct i2c_adapter *adapter)
}
adapter->dev.id = adapter->nr;
+ adapter->dev.detect = i2c_bus_detect;
dev_set_name(&adapter->dev, "i2c");
ret = register_device(&adapter->dev);
@@ -726,8 +735,8 @@ int i2c_add_numbered_adapter(struct i2c_adapter *adapter)
hw_dev = adapter->dev.parent;
if (hw_dev && dev_of_node(hw_dev)) {
if (!hw_dev->detect)
- hw_dev->detect = i2c_bus_detect;
- i2c_bus_detect(hw_dev);
+ hw_dev->detect = i2c_hw_detect;
+ i2c_hw_detect(hw_dev);
}
return 0;
--
2.30.2
next reply other threads:[~2023-01-25 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 7:53 Ahmad Fatoum [this message]
2023-01-25 9:27 ` Marco Felsch
2023-01-25 9:43 ` Ahmad Fatoum
2023-01-26 8:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125075323.1759934-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox