From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 25 Jan 2023 10:28:51 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pKc5N-001KJV-84 for lore@lore.pengutronix.de; Wed, 25 Jan 2023 10:28:51 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKc5K-0007Fn-M6 for lore@pengutronix.de; Wed, 25 Jan 2023 10:28:51 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DO7GaVmxVH2/n8DVbe3V/X3fwCRt1pvWx1Uk1SYxfDc=; b=QTo48AeN91EGVEllabQPLrUDIh PJbkotTZMiPZkoE85Rkr6i0cnG97g+YEEYGyrGgI2Wjg0IARU0JsKsaE2zOpRxKiEPcOZzY4HlYQy bKw9UV8hFTiXWmA4WG1Wb1GNdn9BvPDUtLCroAasB8L6c6KFc9Tcichd5D/HprBQsuf22RN5posSX CR7kRzuKNSqnSeB2YnPdoeMontLKEAf+U32I/aeP9dI1zxfCfnXEzwpabnHsJCBU3NZA052EqhdmX sB80HIQjyz+QLaMRzcb/viuRpCNWsl2rhhq9Jo3V29tZhhddEDzpnE6I9BLeOzQIb/fWo/OyZvPgH xjMq4rbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKc47-006cDO-GK; Wed, 25 Jan 2023 09:27:35 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKc43-006cCh-9U for barebox@lists.infradead.org; Wed, 25 Jan 2023 09:27:32 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKc41-00071W-FA; Wed, 25 Jan 2023 10:27:29 +0100 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pKc41-0006oH-7W; Wed, 25 Jan 2023 10:27:29 +0100 Date: Wed, 25 Jan 2023 10:27:29 +0100 From: Marco Felsch To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20230125092729.g6gquwed7nderrxw@pengutronix.de> References: <20230125075323.1759934-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125075323.1759934-1-a.fatoum@pengutronix.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_012731_347223_375B4788 X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] i2c: implement detect callback for virtual adapter device as well X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hi Ahmad, On 23-01-25, Ahmad Fatoum wrote: > For MMCs, we already support detect on both the hardware device and the > mmcX virtual device. Let's do the same for i2c, so users have the option > to do `detect i2c0` instead of `detect 30a30000.i2c@30a30000.of`. nice :) > `detect -a` still works as expected, as the detect callback is a no-op > if everything on the bus is already registered. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > drivers/i2c/i2c.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/i2c.c b/drivers/i2c/i2c.c > index 7e1cea49f3b6..4ecf7bb163e6 100644 > --- a/drivers/i2c/i2c.c > +++ b/drivers/i2c/i2c.c > @@ -472,6 +472,14 @@ int of_i2c_register_devices_by_node(struct device_node *node) > } > > static int i2c_bus_detect(struct device *dev) > +{ > + struct i2c_adapter *adap = container_of(dev, struct i2c_adapter, dev); > + > + of_i2c_register_devices(adap); > + return 0; > +} > + > +static int i2c_hw_detect(struct device *dev) > { > struct i2c_adapter *adap; > > @@ -712,6 +720,7 @@ int i2c_add_numbered_adapter(struct i2c_adapter *adapter) > } > > adapter->dev.id = adapter->nr; > + adapter->dev.detect = i2c_bus_detect; > dev_set_name(&adapter->dev, "i2c"); > > ret = register_device(&adapter->dev); > @@ -726,8 +735,8 @@ int i2c_add_numbered_adapter(struct i2c_adapter *adapter) > hw_dev = adapter->dev.parent; > if (hw_dev && dev_of_node(hw_dev)) { > if (!hw_dev->detect) > - hw_dev->detect = i2c_bus_detect; > - i2c_bus_detect(hw_dev); > + hw_dev->detect = i2c_hw_detect; > + i2c_hw_detect(hw_dev); > } > > return 0; > -- > 2.30.2 > > >