From: Sascha Hauer <sha@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: John Watts <contact@jookia.org>, barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ARM: novena: Add Kosagi Novena board
Date: Thu, 26 Jan 2023 08:25:35 +0100 [thread overview]
Message-ID: <20230126072535.GE13319@pengutronix.de> (raw)
In-Reply-To: <20230125193357.tdtpryxe5au6vne6@pengutronix.de>
On Wed, Jan 25, 2023 at 08:33:57PM +0100, Marco Felsch wrote:
> Hi John,
>
> thanks for your patch.
>
> On 23-01-26, John Watts wrote:
> > The Kosagi Novena is an open source laptop released in 2014.
> >
> > This patch adds the initial project skeleton for running the PBL
> > and debugging over the UART2 port (labeled DEBUG on the board.)
> >
> > Signed-off-by: John Watts <contact@jookia.org>
> > ---
> > arch/arm/boards/Makefile | 1 +
> > arch/arm/boards/novena/Makefile | 4 +
> > arch/arm/boards/novena/board.c | 26 +++++++
> > .../boards/novena/flash-header-novena.imxcfg | 6 ++
> > arch/arm/boards/novena/lowlevel.c | 73 +++++++++++++++++++
> > arch/arm/configs/imx_v7_defconfig | 1 +
> > arch/arm/dts/Makefile | 1 +
> > arch/arm/dts/imx6q-novena.dts | 4 +
> > arch/arm/mach-imx/Kconfig | 6 ++
> > images/Makefile.imx | 2 +
> > 10 files changed, 124 insertions(+)
> > create mode 100644 arch/arm/boards/novena/Makefile
> > create mode 100644 arch/arm/boards/novena/board.c
> > create mode 100644 arch/arm/boards/novena/flash-header-novena.imxcfg
> > create mode 100644 arch/arm/boards/novena/lowlevel.c
> > create mode 100644 arch/arm/dts/imx6q-novena.dts
> >
> > diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
> > index f47aea6602..50088886eb 100644
> > --- a/arch/arm/boards/Makefile
> > +++ b/arch/arm/boards/Makefile
> > @@ -19,6 +19,7 @@ obj-$(CONFIG_MACH_BEAGLEBONE) += beaglebone/
> > obj-$(CONFIG_MACH_CANON_A1100) += canon-a1100/
> > obj-$(CONFIG_MACH_CM_FX6) += cm-fx6/
> > obj-$(CONFIG_MACH_NITROGEN6) += boundarydevices-nitrogen6/
> > +obj-$(CONFIG_MACH_NOVENA) += novena/
> > obj-$(CONFIG_MACH_CCMX51) += ccxmx51/
> > obj-$(CONFIG_MACH_CCMX53) += ccxmx53/
> > obj-$(CONFIG_MACH_CFA10036) += crystalfontz-cfa10036/
> > + if (!running_from_ram()) {
> > + imx6_ungate_all_peripherals();
> > + setup_uart();
> > + load_barebox();
> > + } else {
> > + boot_barebox();
> > + }
>
> This could be re-written to:
>
> imx6_ungate_all_peripherals();
>
> if (IS_ENABLED(CONFIG_DEBUG_LL))
> setup_uart();
setup_uart() also calls pbl_set_putc() to support PBL console. This is
useful without CONFIG_DEBUG_LL enabled, so please call it
unconditionally.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-01-26 7:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 17:51 [PATCH 0/5] Add support for the " John Watts
2023-01-22 17:51 ` [PATCH 1/5] ARM: novena: Add " John Watts
2023-01-23 9:20 ` Sascha Hauer
2023-01-22 17:51 ` [PATCH 2/5] ARM: novena: Setup RAM using static configuration John Watts
2023-01-22 17:51 ` [PATCH 3/5] ARM: novena: Require the PFUZE regulator John Watts
2023-01-22 17:51 ` [PATCH 4/5] ARM: novena: Read Ethernet MAC address from EEPROM John Watts
2023-01-23 9:33 ` Sascha Hauer
2023-01-23 9:55 ` John Watts
2023-01-24 18:35 ` John Watts
2023-01-25 8:04 ` Sascha Hauer
2023-01-25 8:11 ` John Watts
2023-01-25 8:19 ` Sascha Hauer
2023-01-25 13:31 ` John Watts
2023-01-25 13:48 ` Ahmad Fatoum
2023-01-25 14:04 ` John Watts
2023-01-25 14:16 ` Ahmad Fatoum
2023-01-25 14:28 ` John Watts
2023-01-25 14:33 ` Ahmad Fatoum
2023-01-25 14:50 ` John Watts
2023-01-25 15:42 ` Sascha Hauer
2023-01-25 16:13 ` John Watts
2023-01-22 17:51 ` [PATCH 5/5] ARM: novena: Use DDR3 information from SPD EEPROM John Watts
2023-01-22 23:20 ` John Watts
2023-01-25 16:42 ` [PATCH v2 0/4] Add support for the Kosagi Novena board John Watts
2023-01-25 16:42 ` [PATCH v2 1/4] ARM: novena: Add " John Watts
2023-01-25 19:33 ` Marco Felsch
2023-01-26 7:25 ` Sascha Hauer [this message]
2023-01-26 7:50 ` John Watts
2023-01-26 9:13 ` Marco Felsch
2023-01-25 16:42 ` [PATCH v2 2/4] ARM: novena: Setup RAM using static configuration John Watts
2023-01-25 19:39 ` Marco Felsch
2023-01-26 7:54 ` John Watts
2023-01-26 8:11 ` Sascha Hauer
2023-01-26 9:14 ` Marco Felsch
2023-01-25 16:42 ` [PATCH v2 3/4] ARM: novena: Read Ethernet MAC address from EEPROM John Watts
2023-01-25 20:07 ` Marco Felsch
2023-01-26 8:05 ` John Watts
2023-01-26 9:07 ` Marco Felsch
2023-01-25 16:42 ` [PATCH v2 4/4] ARM: novena: Use DDR3 information from SPD EEPROM John Watts
2023-01-29 23:27 ` [PATCH v3 0/4] Add support for the Kosagi Novena board John Watts
2023-01-29 23:27 ` [PATCH v3 1/4] ARM: novena: Add " John Watts
2023-01-30 20:13 ` Marco Felsch
2023-01-30 20:26 ` John Watts
2023-01-31 9:45 ` Marco Felsch
2023-01-29 23:27 ` [PATCH v3 2/4] ARM: novena: Setup RAM using static configuration John Watts
2023-01-29 23:27 ` [PATCH v3 3/4] ARM: novena: Read Ethernet MAC address from EEPROM John Watts
2023-01-30 20:04 ` Marco Felsch
2023-01-30 20:25 ` John Watts
2023-01-31 9:29 ` Marco Felsch
2023-01-29 23:28 ` [PATCH v3 4/4] ARM: novena: Use DDR3 information from SPD EEPROM John Watts
2023-01-30 20:18 ` Marco Felsch
2023-01-30 20:41 ` John Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126072535.GE13319@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=contact@jookia.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox