From: Sascha Hauer <sha@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 1/3] ARM: i.MX8M: esdctl: use common compatible to detect i.MX8MQ/MM/MP DDRC
Date: Fri, 10 Feb 2023 10:41:47 +0100 [thread overview]
Message-ID: <20230210094147.GR10447@pengutronix.de> (raw)
In-Reply-To: <20230208133408.1114573-1-l.stach@pengutronix.de>
On Wed, Feb 08, 2023 at 02:34:06PM +0100, Lucas Stach wrote:
> All i.MX8M* DDRC nodes are compatible to "fsl,imx8m-ddrc". As the memory
> size detection works the same on most of them, with the only exception
> being the i.MX8MN, which only has a 16bit data bus, there is no need to
> match the more specific compatibles for i.MX8MQ/MM/MP.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> arch/arm/mach-imx/esdctl.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/mach-imx/esdctl.c b/arch/arm/mach-imx/esdctl.c
> index a704250297bb..29e992933421 100644
> --- a/arch/arm/mach-imx/esdctl.c
> +++ b/arch/arm/mach-imx/esdctl.c
> @@ -652,7 +652,7 @@ static __maybe_unused struct imx_esdctl_data vf610_data = {
> .add_mem = vf610_ddrmc_add_mem,
> };
>
> -static __maybe_unused struct imx_esdctl_data imx8mq_data = {
> +static __maybe_unused struct imx_esdctl_data imx8m_data = {
> .base0 = MX8M_DDR_CSD1_BASE_ADDR,
> .add_mem = imx8m_ddrc_add_mem,
> };
> @@ -732,14 +732,11 @@ static __maybe_unused struct of_device_id imx_esdctl_dt_ids[] = {
> .compatible = "fsl,vf610-ddrmc",
> .data = &vf610_data
> }, {
> - .compatible = "fsl,imx8mm-ddrc",
> - .data = &imx8mq_data
> + .compatible = "fsl,imx8m-ddrc",
> + .data = &imx8m_data
> }, {
> .compatible = "fsl,imx8mn-ddrc",
> .data = &imx8mn_data
> - }, {
> - .compatible = "fsl,imx8mq-ddrc",
> - .data = &imx8mq_data
> }, {
> .compatible = "fsl,imx7d-ddrc",
> .data = &imx7d_data
> --
> 2.39.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-02-10 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 13:34 Lucas Stach
2023-02-08 13:34 ` [PATCH v3 2/3] ARM: dts: i.MX8MP: add DDRC compatibles Lucas Stach
2023-02-08 13:34 ` [PATCH v3 3/3] ARM: dts: i.MX8MP: remove DSP and DSP reserved memory nodes Lucas Stach
2023-02-10 9:41 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210094147.GR10447@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox