[PATCH 0/2] Initial LS1021-IOT board support

[PATCH 0/2] Initial LS1021-IOT board support

[Renaud Barbier]

The LS1021A-IOT is NXP ARMv7 Layerscape evaluation board.

These patches provide a basic board support with:
	- UART
	- boot from SPI
	- One Ethernet port - eth1*

The content of the EEPROM having been lost so the MAC should be set in the
config file

The code is ported from NXP U-boot 2021-04. Like U-boot, the machine support
i.e mac-lxxx lives in its own directory. However, it is very similar to the 
ls1046a machine support. This migth be merged. Please advise.

Renaud Barbier (2):
  ARM: Add Layerscape v7 support
  ARM: Layerscape: Add LS1021A IOT board support

 arch/arm/Kconfig                              |  12 +
 arch/arm/Makefile                             |   1 +
 arch/arm/boards/Makefile                      |   1 +
 arch/arm/boards/ls1021aiot/Makefile           |   3 +
 arch/arm/boards/ls1021aiot/board.c            |  83 ++++
 arch/arm/boards/ls1021aiot/lowlevel.c         | 121 ++++++
 arch/arm/boards/ls1021aiot/ls102xa_pbi.cfg    |  11 +
 .../boards/ls1021aiot/ls102xa_rcw_sd_qspi.cfg |   8 +
 arch/arm/boards/ls1021aiot/start.S            |  11 +
 arch/arm/configs/layerscape_v7_defconfig      | 100 +++++
 arch/arm/dts/Makefile                         |   1 +
 arch/arm/dts/fsl-ls1021a-iot.dts              | 124 ++++++
 arch/arm/lib32/Makefile                       |   1 +
 arch/arm/lib32/pbl.c                          |  21 +
 arch/arm/mach-ls102xa/Kconfig                 |  22 +
 arch/arm/mach-ls102xa/Makefile                |   9 +
 arch/arm/mach-ls102xa/boot.c                  |  39 ++
 arch/arm/mach-ls102xa/errata.c                | 112 +++++
 arch/arm/mach-ls102xa/include/mach/debug_ll.h |  36 ++
 arch/arm/mach-ls102xa/include/mach/errata.h   |   9 +
 arch/arm/mach-ls102xa/include/mach/fsl_epu.h  |  73 ++++
 .../mach-ls102xa/include/mach/layerscape.h    |  11 +
 arch/arm/mach-ls102xa/include/mach/lowlevel.h |   8 +
 arch/arm/mach-ls102xa/include/mach/xload.h    |  14 +
 arch/arm/mach-ls102xa/lowlevel-ls102xa.c      | 378 ++++++++++++++++
 arch/arm/mach-ls102xa/ls102xa_stream_id.c     |  46 ++
 arch/arm/mach-ls102xa/ls102xa_stream_id.h     |  17 +
 arch/arm/mach-ls102xa/pblimage.c              |  60 +++
 arch/arm/mach-ls102xa/restart.c               |  27 ++
 arch/arm/mach-ls102xa/xload-qspi.c            |  34 ++
 arch/arm/mach-ls102xa/xload.c                 |  22 +
 common/Kconfig                                |   2 +-
 drivers/clk/Makefile                          |   1 +
 drivers/ddr/fsl/Kconfig                       |   2 +-
 drivers/i2c/busses/Kconfig                    |   2 +-
 drivers/net/Kconfig                           |   2 +-
 drivers/net/gianfar.c                         | 211 ++++++++-
 drivers/net/gianfar.h                         |  16 +-
 images/Makefile.layerscape                    |   9 +
 include/soc/fsl/immap_ls102xa.h               | 408 ++++++++++++++++++
 scripts/Kconfig                               |   4 +-
 41 files changed, 2044 insertions(+), 28 deletions(-)
 create mode 100644 arch/arm/boards/ls1021aiot/Makefile
 create mode 100644 arch/arm/boards/ls1021aiot/board.c
 create mode 100644 arch/arm/boards/ls1021aiot/lowlevel.c
 create mode 100644 arch/arm/boards/ls1021aiot/ls102xa_pbi.cfg
 create mode 100644 arch/arm/boards/ls1021aiot/ls102xa_rcw_sd_qspi.cfg
 create mode 100644 arch/arm/boards/ls1021aiot/start.S
 create mode 100644 arch/arm/configs/layerscape_v7_defconfig
 create mode 100644 arch/arm/dts/fsl-ls1021a-iot.dts
 create mode 100644 arch/arm/lib32/pbl.c
 create mode 100644 arch/arm/mach-ls102xa/Kconfig
 create mode 100644 arch/arm/mach-ls102xa/Makefile
 create mode 100644 arch/arm/mach-ls102xa/boot.c
 create mode 100644 arch/arm/mach-ls102xa/errata.c
 create mode 100644 arch/arm/mach-ls102xa/include/mach/debug_ll.h
 create mode 100644 arch/arm/mach-ls102xa/include/mach/errata.h
 create mode 100644 arch/arm/mach-ls102xa/include/mach/fsl_epu.h
 create mode 100644 arch/arm/mach-ls102xa/include/mach/layerscape.h
 create mode 100644 arch/arm/mach-ls102xa/include/mach/lowlevel.h
 create mode 100644 arch/arm/mach-ls102xa/include/mach/xload.h
 create mode 100644 arch/arm/mach-ls102xa/lowlevel-ls102xa.c
 create mode 100644 arch/arm/mach-ls102xa/ls102xa_stream_id.c
 create mode 100644 arch/arm/mach-ls102xa/ls102xa_stream_id.h
 create mode 100644 arch/arm/mach-ls102xa/pblimage.c
 create mode 100644 arch/arm/mach-ls102xa/restart.c
 create mode 100644 arch/arm/mach-ls102xa/xload-qspi.c
 create mode 100644 arch/arm/mach-ls102xa/xload.c
 create mode 100644 include/soc/fsl/immap_ls102xa.h

Re: [PATCH 0/2] Initial LS1021-IOT board support

[Sascha Hauer]

On Wed, Feb 08, 2023 at 01:26:21PM +0000, Renaud Barbier wrote:
> The LS1021A-IOT is NXP ARMv7 Layerscape evaluation board.
> 
> These patches provide a basic board support with:
> 	- UART
> 	- boot from SPI
> 	- One Ethernet port - eth1*
> 
> The content of the EEPROM having been lost so the MAC should be set in the
> config file
> 
> The code is ported from NXP U-boot 2021-04. Like U-boot, the machine support
> i.e mac-lxxx lives in its own directory. However, it is very similar to the 
> ls1046a machine support. This migth be merged. Please advise.

It would be nice to have this merged to arch/arm/mach-layerscape. For
example arch/arm/mach-layerscape/pblimage.c looks identical to your
version.

Have you tried merging it? If yes, which problems did you encounter?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [PATCH 0/2] Initial LS1021-IOT board support

[Renaud Barbier]

I have not tried yet. I was not sure if you like to have separate machine support as there are some differences in the SOC .

I will merge it and send you a new patch.

> -----Original Message-----
> From: Sascha Hauer <sha@pengutronix.de>
> Sent: 10 February 2023 11:26
> To: Renaud Barbier <Renaud.Barbier@ametek.com>
> Cc: Barebox List <barebox@lists.infradead.org>
> Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support
> 
> ***NOTICE*** This came from an external source. Use caution when
> replying, clicking links, or opening attachments.
> 
> On Wed, Feb 08, 2023 at 01:26:21PM +0000, Renaud Barbier wrote:
> > The LS1021A-IOT is NXP ARMv7 Layerscape evaluation board.
> >
> > These patches provide a basic board support with:
> >       - UART
> >       - boot from SPI
> >       - One Ethernet port - eth1*
> >
> > The content of the EEPROM having been lost so the MAC should be set in
> > the config file
> >
> > The code is ported from NXP U-boot 2021-04. Like U-boot, the machine
> > support i.e mac-lxxx lives in its own directory. However, it is very
> > similar to the ls1046a machine support. This migth be merged. Please
> advise.
> 
> It would be nice to have this merged to arch/arm/mach-layerscape. For
> example arch/arm/mach-layerscape/pblimage.c looks identical to your
> version.
> 
> Have you tried merging it? If yes, which problems did you encounter?
> 
> Sascha
> 
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       |
> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!C
> ZdG8RU9gQpSVfJzH_T4b8q5lFRdLrpGiJsD5H-
> H351N8ycvCriKuoi6quenVmESFrbU0Iw9qhIlb5z4ifTE$   |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH 0/2] Initial LS1021-IOT board support

[Sascha Hauer]

On Fri, Feb 10, 2023 at 11:54:31AM +0000, Renaud Barbier wrote:
> I have not tried yet. I was not sure if you like to have separate machine support as there are some differences in the SOC .
> 
> I will merge it and send you a new patch.

I like it better when it's merged, eventhough it's never compiled
together as they are different compiler architectures.

Sascha

> 
> > -----Original Message-----
> > From: Sascha Hauer <sha@pengutronix.de>
> > Sent: 10 February 2023 11:26
> > To: Renaud Barbier <Renaud.Barbier@ametek.com>
> > Cc: Barebox List <barebox@lists.infradead.org>
> > Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support
> > 
> > ***NOTICE*** This came from an external source. Use caution when
> > replying, clicking links, or opening attachments.
> > 
> > On Wed, Feb 08, 2023 at 01:26:21PM +0000, Renaud Barbier wrote:
> > > The LS1021A-IOT is NXP ARMv7 Layerscape evaluation board.
> > >
> > > These patches provide a basic board support with:
> > >       - UART
> > >       - boot from SPI
> > >       - One Ethernet port - eth1*
> > >
> > > The content of the EEPROM having been lost so the MAC should be set in
> > > the config file
> > >
> > > The code is ported from NXP U-boot 2021-04. Like U-boot, the machine
> > > support i.e mac-lxxx lives in its own directory. However, it is very
> > > similar to the ls1046a machine support. This migth be merged. Please
> > advise.
> > 
> > It would be nice to have this merged to arch/arm/mach-layerscape. For
> > example arch/arm/mach-layerscape/pblimage.c looks identical to your
> > version.
> > 
> > Have you tried merging it? If yes, which problems did you encounter?
> > 
> > Sascha
> > 
> > --
> > Pengutronix e.K.                           |                             |
> > Steuerwalder Str. 21                       |
> > https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!C
> > ZdG8RU9gQpSVfJzH_T4b8q5lFRdLrpGiJsD5H-
> > H351N8ycvCriKuoi6quenVmESFrbU0Iw9qhIlb5z4ifTE$   |
> > 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [PATCH 0/2] Initial LS1021-IOT board support

[Renaud Barbier]

What about soc/fsl/immap_lsch2.h vs soc/fsl/immap_ls102xa.h.
Lots of similarities but also a lots of differences (when excluding the prefix LSCH2 and LS102XA)
Can I assume ccsr_scfg can be mapped to each other?
May be a question to NXP.


> -----Original Message-----
> From: Sascha Hauer <sha@pengutronix.de>
> Sent: 10 February 2023 12:26
> To: Renaud Barbier <Renaud.Barbier@ametek.com>
> Cc: Barebox List <barebox@lists.infradead.org>
> Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support
> 
> ***NOTICE*** This came from an external source. Use caution when
> replying, clicking links, or opening attachments.
> 
> On Fri, Feb 10, 2023 at 11:54:31AM +0000, Renaud Barbier wrote:
> > I have not tried yet. I was not sure if you like to have separate machine
> support as there are some differences in the SOC .
> >
> > I will merge it and send you a new patch.
> 
> I like it better when it's merged, eventhough it's never compiled together as
> they are different compiler architectures.
> 
> Sascha
> 
> >
> > > -----Original Message-----
> > > From: Sascha Hauer <sha@pengutronix.de>
> > > Sent: 10 February 2023 11:26
> > > To: Renaud Barbier <Renaud.Barbier@ametek.com>
> > > Cc: Barebox List <barebox@lists.infradead.org>
> > > Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support
> > >
> > > ***NOTICE*** This came from an external source. Use caution when
> > > replying, clicking links, or opening attachments.
> > >
> > > On Wed, Feb 08, 2023 at 01:26:21PM +0000, Renaud Barbier wrote:
> > > > The LS1021A-IOT is NXP ARMv7 Layerscape evaluation board.
> > > >
> > > > These patches provide a basic board support with:
> > > >       - UART
> > > >       - boot from SPI
> > > >       - One Ethernet port - eth1*
> > > >
> > > > The content of the EEPROM having been lost so the MAC should be
> > > > set in the config file
> > > >
> > > > The code is ported from NXP U-boot 2021-04. Like U-boot, the
> > > > machine support i.e mac-lxxx lives in its own directory. However,
> > > > it is very similar to the ls1046a machine support. This migth be
> > > > merged. Please
> > > advise.
> > >
> > > It would be nice to have this merged to arch/arm/mach-layerscape.
> > > For example arch/arm/mach-layerscape/pblimage.c looks identical to
> > > your version.
> > >
> > > Have you tried merging it? If yes, which problems did you encounter?
> > >
> > > Sascha
> > >
> > > --
> > > Pengutronix e.K.                           |                             |
> > > Steuerwalder Str. 21                       |
> > >
> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!C
> > > ZdG8RU9gQpSVfJzH_T4b8q5lFRdLrpGiJsD5H-
> > > H351N8ycvCriKuoi6quenVmESFrbU0Iw9qhIlb5z4ifTE$   |
> > > 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> > > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> >
> 
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       |
> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!G
> os0mqldKVyCzyhvalaS58FEkUQ1osWODWWtH0-
> MC4aIxC0d2rtcUzK3DWcfHooti_U0whPPLXjo8H3Xl87E$   |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH 0/2] Initial LS1021-IOT board support

[Ahmad Fatoum]

Hello Renaud,

On 10.02.23 16:57, Renaud Barbier wrote:
> What about soc/fsl/immap_lsch2.h vs soc/fsl/immap_ls102xa.h.
> Lots of similarities but also a lots of differences (when excluding the prefix LSCH2 and LS102XA)
> Can I assume ccsr_scfg can be mapped to each other?
> May be a question to NXP.

Preferably, you'd use the already defined macros and for stuff where
LS102x differs, you'd add a prefix, e.g. struct ls102x_ccsr_scfg.

The goal should be to have as little duplication as possible
and still be able to compile a file that includes both
headers without them clashing.

Cheers,
Ahmad

> 
> 
>> -----Original Message-----
>> From: Sascha Hauer <sha@pengutronix.de>
>> Sent: 10 February 2023 12:26
>> To: Renaud Barbier <Renaud.Barbier@ametek.com>
>> Cc: Barebox List <barebox@lists.infradead.org>
>> Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support
>>
>> ***NOTICE*** This came from an external source. Use caution when
>> replying, clicking links, or opening attachments.
>>
>> On Fri, Feb 10, 2023 at 11:54:31AM +0000, Renaud Barbier wrote:
>>> I have not tried yet. I was not sure if you like to have separate machine
>> support as there are some differences in the SOC .
>>>
>>> I will merge it and send you a new patch.
>>
>> I like it better when it's merged, eventhough it's never compiled together as
>> they are different compiler architectures.
>>
>> Sascha
>>
>>>
>>>> -----Original Message-----
>>>> From: Sascha Hauer <sha@pengutronix.de>
>>>> Sent: 10 February 2023 11:26
>>>> To: Renaud Barbier <Renaud.Barbier@ametek.com>
>>>> Cc: Barebox List <barebox@lists.infradead.org>
>>>> Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support
>>>>
>>>> ***NOTICE*** This came from an external source. Use caution when
>>>> replying, clicking links, or opening attachments.
>>>>
>>>> On Wed, Feb 08, 2023 at 01:26:21PM +0000, Renaud Barbier wrote:
>>>>> The LS1021A-IOT is NXP ARMv7 Layerscape evaluation board.
>>>>>
>>>>> These patches provide a basic board support with:
>>>>>       - UART
>>>>>       - boot from SPI
>>>>>       - One Ethernet port - eth1*
>>>>>
>>>>> The content of the EEPROM having been lost so the MAC should be
>>>>> set in the config file
>>>>>
>>>>> The code is ported from NXP U-boot 2021-04. Like U-boot, the
>>>>> machine support i.e mac-lxxx lives in its own directory. However,
>>>>> it is very similar to the ls1046a machine support. This migth be
>>>>> merged. Please
>>>> advise.
>>>>
>>>> It would be nice to have this merged to arch/arm/mach-layerscape.
>>>> For example arch/arm/mach-layerscape/pblimage.c looks identical to
>>>> your version.
>>>>
>>>> Have you tried merging it? If yes, which problems did you encounter?
>>>>
>>>> Sascha
>>>>
>>>> --
>>>> Pengutronix e.K.                           |                             |
>>>> Steuerwalder Str. 21                       |
>>>>
>> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!C
>>>> ZdG8RU9gQpSVfJzH_T4b8q5lFRdLrpGiJsD5H-
>>>> H351N8ycvCriKuoi6quenVmESFrbU0Iw9qhIlb5z4ifTE$   |
>>>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>>>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>>
>>
>> --
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       |
>> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!G
>> os0mqldKVyCzyhvalaS58FEkUQ1osWODWWtH0-
>> MC4aIxC0d2rtcUzK3DWcfHooti_U0whPPLXjo8H3Xl87E$   |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |