mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] of: describe third arg of of_property_write_bool in kerneldoc
Date: Fri, 17 Feb 2023 10:46:22 +0100	[thread overview]
Message-ID: <20230217094622.GQ10447@pengutronix.de> (raw)
In-Reply-To: <20230216105722.2865178-1-a.fatoum@pengutronix.de>

On Thu, Feb 16, 2023 at 11:57:22AM +0100, Ahmad Fatoum wrote:
> of_property_write_bool takes a third argument describing whether to
> unset (delete) the property or to set it. Describe it in the kerneldoc.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/of/base.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 937847f44ab7..1d8b207b1528 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1130,6 +1130,7 @@ EXPORT_SYMBOL_GPL(of_prop_next_string);
>   *
>   * @np:		device node from which the property is to be set.
>   * @propname:	name of the property to be set.
> + * @value	true to set, false to delete
>   *
>   * Search for a property in a device node and create or delete the property.
>   * If the property already exists and write value is false, the property is
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-02-17  9:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 10:57 Ahmad Fatoum
2023-02-17  9:46 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217094622.GQ10447@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox