* [PATCH] net: make DRIVER_NET_DESIGNWARE_IMX8 select MFD_SYSCON
@ 2023-02-22 12:23 Bastian Krause
2023-02-22 12:40 ` Ahmad Fatoum
2023-02-23 9:32 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Bastian Krause @ 2023-02-22 12:23 UTC (permalink / raw)
To: barebox; +Cc: lst, afa, Bastian Krause
The driver includes mfd/syscon.h and uses
syscon_regmap_lookup_by_phandle():
eqos-imx8 30bf0000.ethernet@30bf0000.of: probe failed: Function not implemented
Select MFD_SYSCON to fix this.
Fixes: b6fb740819 ("net: eqos: add i.MX8MP support")
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index a9fc073d57..25b46ccb11 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -111,6 +111,7 @@ config DRIVER_NET_DESIGNWARE_IMX8
bool "Designware EQOS i.MX8 Ethernet driver"
depends on HAS_DMA && COMMON_CLK && OFTREE && (ARCH_IMX8M || COMPILE_TEST)
select DRIVER_NET_DESIGNWARE_EQOS
+ select MFD_SYSCON
help
This option enables support for the Designware EQOS MAC implemented on
the NXP i.MX8 SoCs.
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: make DRIVER_NET_DESIGNWARE_IMX8 select MFD_SYSCON
2023-02-22 12:23 [PATCH] net: make DRIVER_NET_DESIGNWARE_IMX8 select MFD_SYSCON Bastian Krause
@ 2023-02-22 12:40 ` Ahmad Fatoum
2023-02-23 9:32 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2023-02-22 12:40 UTC (permalink / raw)
To: Bastian Krause, barebox; +Cc: lst, afa
On 22.02.23 13:23, Bastian Krause wrote:
> The driver includes mfd/syscon.h and uses
> syscon_regmap_lookup_by_phandle():
>
> eqos-imx8 30bf0000.ethernet@30bf0000.of: probe failed: Function not implemented
>
> Select MFD_SYSCON to fix this.
>
> Fixes: b6fb740819 ("net: eqos: add i.MX8MP support")
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Driver is still in next, so this could be squashed.
Cheers,
Ahmad
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index a9fc073d57..25b46ccb11 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -111,6 +111,7 @@ config DRIVER_NET_DESIGNWARE_IMX8
> bool "Designware EQOS i.MX8 Ethernet driver"
> depends on HAS_DMA && COMMON_CLK && OFTREE && (ARCH_IMX8M || COMPILE_TEST)
> select DRIVER_NET_DESIGNWARE_EQOS
> + select MFD_SYSCON
> help
> This option enables support for the Designware EQOS MAC implemented on
> the NXP i.MX8 SoCs.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: make DRIVER_NET_DESIGNWARE_IMX8 select MFD_SYSCON
2023-02-22 12:23 [PATCH] net: make DRIVER_NET_DESIGNWARE_IMX8 select MFD_SYSCON Bastian Krause
2023-02-22 12:40 ` Ahmad Fatoum
@ 2023-02-23 9:32 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2023-02-23 9:32 UTC (permalink / raw)
To: Bastian Krause; +Cc: barebox, lst, afa
On Wed, Feb 22, 2023 at 01:23:20PM +0100, Bastian Krause wrote:
> The driver includes mfd/syscon.h and uses
> syscon_regmap_lookup_by_phandle():
>
> eqos-imx8 30bf0000.ethernet@30bf0000.of: probe failed: Function not implemented
>
> Select MFD_SYSCON to fix this.
>
> Fixes: b6fb740819 ("net: eqos: add i.MX8MP support")
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index a9fc073d57..25b46ccb11 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -111,6 +111,7 @@ config DRIVER_NET_DESIGNWARE_IMX8
> bool "Designware EQOS i.MX8 Ethernet driver"
> depends on HAS_DMA && COMMON_CLK && OFTREE && (ARCH_IMX8M || COMPILE_TEST)
> select DRIVER_NET_DESIGNWARE_EQOS
> + select MFD_SYSCON
> help
> This option enables support for the Designware EQOS MAC implemented on
> the NXP i.MX8 SoCs.
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-23 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-22 12:23 [PATCH] net: make DRIVER_NET_DESIGNWARE_IMX8 select MFD_SYSCON Bastian Krause
2023-02-22 12:40 ` Ahmad Fatoum
2023-02-23 9:32 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox