mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 7/8] ARM: dts: imx7d-peb-eval-02: Fix dtc warnings
Date: Thu, 2 Mar 2023 12:17:13 +0100	[thread overview]
Message-ID: <20230302111713.gukf2vbkq5prhki3@pengutronix.de> (raw)
In-Reply-To: <20230302105741.GQ32097@pengutronix.de>

On 23-03-02, Sascha Hauer wrote:
> On Thu, Mar 02, 2023 at 11:49:53AM +0100, Marco Felsch wrote:
> > Hi Sascha,
> > 
> > On 23-03-02, Sascha Hauer wrote:
> > > Some nodes have a unit name, but no reg property. Drop the unit name
> > > to avoid dtc warnings.
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > >  arch/arm/dts/imx7d-peb-eval-02.dtsi | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/arch/arm/dts/imx7d-peb-eval-02.dtsi b/arch/arm/dts/imx7d-peb-eval-02.dtsi
> > > index 8bde5b13e7..5c2c302d54 100644
> > > --- a/arch/arm/dts/imx7d-peb-eval-02.dtsi
> > > +++ b/arch/arm/dts/imx7d-peb-eval-02.dtsi
> > > @@ -13,21 +13,21 @@
> > >  		pinctrl-0 = <&pinctrl_leds_eval>;
> > >  		status = "disabled";
> > >  
> > > -		led@0 {
> > > +		led0 {
> > 
> > To follow the binding doc the name should be led-0. For the below nodes
> > as well.
> 
> Fixed, thanks

The rest of the series lgtm, feel free to add my:

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

> 
> Sascha
> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 



  reply	other threads:[~2023-03-02 11:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 10:39 [PATCH 0/8] Fix/avoid " Sascha Hauer
2023-03-02 10:39 ` [PATCH 1/8] scripts: dtc: disable interrupt_provider warnings Sascha Hauer
2023-03-02 10:39 ` [PATCH 2/8] ARM: dts: digic4: Fix dtc warnings Sascha Hauer
2023-03-02 10:39 ` [PATCH 3/8] ARM: dts: ep7212-clep7212: " Sascha Hauer
2023-03-02 10:39 ` [PATCH 4/8] ARM: dts: Fix dtc warnings in state nodes Sascha Hauer
2023-03-02 10:39 ` [PATCH 5/8] ARM: dts: Fix dtc warnings in barebox,environment nodes Sascha Hauer
2023-03-02 10:39 ` [PATCH 6/8] ARM: dts: imx7d-peb-av-02: Fix dtc warning Sascha Hauer
2023-03-02 10:39 ` [PATCH 7/8] ARM: dts: imx7d-peb-eval-02: Fix dtc warnings Sascha Hauer
2023-03-02 10:49   ` Marco Felsch
2023-03-02 10:57     ` Sascha Hauer
2023-03-02 11:17       ` Marco Felsch [this message]
2023-03-02 10:39 ` [PATCH 8/8] ARM: dts: imx6ull-jozacp: Move regulators out of subnode Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302111713.gukf2vbkq5prhki3@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox