From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] blspec: support higher verbosity levels for boot
Date: Thu, 9 Mar 2023 11:52:23 +0100 [thread overview]
Message-ID: <20230309105223.GD5784@pengutronix.de> (raw)
In-Reply-To: <20230308130416.3895317-1-a.fatoum@pengutronix.de>
On Wed, Mar 08, 2023 at 02:04:16PM +0100, Ahmad Fatoum wrote:
> bootm_data::verbose is an integer and may take values higher than one
> for higher levels of verbosity. Yet, boots with blspec always had at
> most a verbosity of one, because verbose was treated as boolean. Fix this.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> common/blspec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/common/blspec.c b/common/blspec.c
> index f6e590b2efd8..97400b9a2248 100644
> --- a/common/blspec.c
> +++ b/common/blspec.c
> @@ -88,7 +88,7 @@ static int blspec_boot(struct bootentry *be, int verbose, int dryrun)
>
> bootm_data_init_defaults(&data);
>
> - data.verbose = verbose || data.verbose;
> + data.verbose = max(verbose, data.verbose);
>
> devicetree = blspec_entry_var_get(entry, "devicetree");
> initrd = blspec_entry_var_get(entry, "initrd");
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-03-09 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 13:04 Ahmad Fatoum
2023-03-09 10:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309105223.GD5784@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox