From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH v2 3/7] i2c: implement rescan
Date: Thu, 9 Mar 2023 12:52:04 +0100 [thread overview]
Message-ID: <20230309115208.973893-4-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20230309115208.973893-1-s.hauer@pengutronix.de>
struct device::rescan is called by the core to let the subsystem rescan
the controllers device node. Implement that for I2C. Ahmad recently
implemented the struct device::detect hook for the very same purpose.
The downside of that approach was that device_detect() had to be called
manually and that either needs knowledge which device actually has
updated device nodes, or all devices were detected, like unrelated USB
or MMC/SD devices. The rescan hook doesn't need that manual detect call,
so just drop the I2C detect implementation in favour for implementing
rescan.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/i2c/i2c.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/i2c/i2c.c b/drivers/i2c/i2c.c
index efcad29342..df89b8fb65 100644
--- a/drivers/i2c/i2c.c
+++ b/drivers/i2c/i2c.c
@@ -471,15 +471,7 @@ int of_i2c_register_devices_by_node(struct device_node *node)
return 0;
}
-static int i2c_bus_detect(struct device *dev)
-{
- struct i2c_adapter *adap = container_of(dev, struct i2c_adapter, dev);
-
- of_i2c_register_devices(adap);
- return 0;
-}
-
-static int i2c_hw_detect(struct device *dev)
+static void i2c_hw_rescan(struct device *dev)
{
struct i2c_adapter *adap;
@@ -489,8 +481,6 @@ static int i2c_hw_detect(struct device *dev)
of_i2c_register_devices(adap);
break;
}
-
- return 0;
}
/**
@@ -720,7 +710,6 @@ int i2c_add_numbered_adapter(struct i2c_adapter *adapter)
}
adapter->dev.id = adapter->nr;
- adapter->dev.detect = i2c_bus_detect;
dev_set_name(&adapter->dev, "i2c");
ret = register_device(&adapter->dev);
@@ -732,11 +721,12 @@ int i2c_add_numbered_adapter(struct i2c_adapter *adapter)
/* populate children from any i2c device tables */
scan_boardinfo(adapter);
+ of_i2c_register_devices(adapter);
+
hw_dev = adapter->dev.parent;
if (hw_dev && dev_of_node(hw_dev)) {
- if (!hw_dev->detect)
- hw_dev->detect = i2c_hw_detect;
- i2c_hw_detect(hw_dev);
+ if (!hw_dev->rescan)
+ hw_dev->rescan = i2c_hw_rescan;
}
return 0;
--
2.30.2
next prev parent reply other threads:[~2023-03-09 12:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 11:52 [PATCH v2 0/7] support overlays to the barebox live tree Sascha Hauer
2023-03-09 11:52 ` [PATCH v2 1/7] kbuild: Add target to build dtb overlay files Sascha Hauer
2023-03-09 13:24 ` Ahmad Fatoum
2023-03-09 15:28 ` Sascha Hauer
2023-03-09 15:33 ` Ahmad Fatoum
2023-03-09 15:35 ` Sascha Hauer
2023-03-09 11:52 ` [PATCH v2 2/7] driver: Add rescan hook to struct device Sascha Hauer
2023-03-09 12:54 ` Ahmad Fatoum
2023-03-09 13:39 ` Ahmad Fatoum
2023-03-09 13:08 ` Ahmad Fatoum
2023-03-09 15:41 ` Sascha Hauer
2023-03-10 8:37 ` Sascha Hauer
2023-03-09 11:52 ` Sascha Hauer [this message]
2023-03-09 13:02 ` [PATCH v2 3/7] i2c: implement rescan Ahmad Fatoum
2023-03-09 15:54 ` Sascha Hauer
2023-03-09 11:52 ` [PATCH v2 4/7] spi: Directly register SPI device Sascha Hauer
2023-03-09 11:52 ` [PATCH v2 5/7] spi: reduce scope of 'chip' Sascha Hauer
2023-03-09 11:52 ` [PATCH v2 6/7] spi: implement rescan Sascha Hauer
2023-03-09 13:03 ` Ahmad Fatoum
2023-03-09 11:52 ` [PATCH v2 7/7] of_overlay: Add option to apply overlay to live tree Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309115208.973893-4-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox