From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 13 Mar 2023 17:17:17 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pbkrM-006sv6-Ik for lore@lore.pengutronix.de; Mon, 13 Mar 2023 17:17:17 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbkrM-0006sl-6h for lore@pengutronix.de; Mon, 13 Mar 2023 17:17:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CKJuE1FQCK+7+sdbP9FOm1GXMtSKPWN9j3sBXMxdU/8=; b=ZNQoEb1OLPfQNtFsHNmbMEKHjm 9BI8gUjNtVosPZ5UNi2qPK6FHHkUuNcHIdc/fvEMfk9dCthA0pZR+K+fTakiE0nDLUSZFge/F/hWB mSVuG96JQYSzbvS5ld+VVeZbMPq4gmHrXl/0GG76SU6gbbf8QMVjdW8ySeisDJ/P81jOH7MrDpMTn f3y+/3m9rnEpQFYiSxptnO5vHVeRcErqJxuRwjJvow+LMcC81dSNXeQ55l5c4mBUWCI12vI72aEZJ Yl3/P+NheMkmLdNwzMK6p9cgL7i/uSqbP7h9b9EL7nwDb2+Gx41yqLapPhttHtEXY5o/HA42mcrSs UPt2OLQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkpa-006gAD-Gi; Mon, 13 Mar 2023 16:15:26 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkiw-006dS8-Qg for barebox@lists.infradead.org; Mon, 13 Mar 2023 16:08:36 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbkir-0005Wi-5O; Mon, 13 Mar 2023 17:08:29 +0100 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pbkiq-0006uy-UK; Mon, 13 Mar 2023 17:08:28 +0100 Date: Mon, 13 Mar 2023 17:08:28 +0100 From: Marco Felsch To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20230313160828.clbmimzfhnsyuy5t@pengutronix.de> References: <20230312162928.2110697-1-m.felsch@pengutronix.de> <4069572b-56f9-c63d-bb04-90e583fe9ea4@pengutronix.de> <20230313134922.d4xvhcibk76mkgb6@pengutronix.de> <90842333-c3dc-898f-b88a-2853856c1290@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90842333-c3dc-898f-b88a-2853856c1290@pengutronix.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_090834_922419_38C9A7B6 X-CRM114-Status: GOOD ( 30.21 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] ARM: dts: i.MX8MP: remove memory node X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 23-03-13, Ahmad Fatoum wrote: > On 13.03.23 14:58, Ahmad Fatoum wrote: > > On 13.03.23 14:49, Marco Felsch wrote: > >> On 23-03-13, Ahmad Fatoum wrote: > >>> On 12.03.23 17:29, Marco Felsch wrote: > >>>> since commit f083fffe52 ("ARM: dts: i.MX8MP: add DDRC compatibles") we > >>>> make use of the esdctl driver. This cause the below error since barebox > >>>> try to add the memory twice. > >>>> > >>>> | imx-esdctl 3d400000.memory-controller@3d400000.of: probe failed: Device or resource busy > >>>> | initcall imx_esdctl_driver_init+0x0/0x2c failed: No such device > >>> > >>> Starting with commit 0a78ac84e9fe ("memory: fuse overlapping memory banks"), > >>> this should not be leading to errors. Can you increase debugging in > >>> common/resource.c and see why you run into this error? > >> > >> I did this and saw that memory bank ram0 is added added twice: > >> - first by generic of > >> - 2nd by esdctl > > > > See the first loop in barebox_add_memory_bank(). If you add > > two overlapping IORESOURCE_MEM banks, the function will not > > s/overlapping/region fully within the other region/ Thanks for the hint, I checked this and now see the issue: - 1st) of_add_memory_bank() add two banks for the 6G option: - ram0: 0x40000000 0xc0000000 - ram1: 0x100000000 0xc0000000 - 2nd) the esdctl dirver try to add only one bank for the 6G: - ram0: 0x40000000 0x180000000 The overlap mechanism is triggered and we enter the barebox_grow_memory_bank() but since we already requested ram1 we can't grow ram0. So the tqm8 board isn't effected and a 'lacy' approach is to remvoe the memory node as suggested by Lucas. Regards, Marco > > > return an error. I think there might be a problem if you run > > into an error. > > > >> > >> Regards, > >> Marco > >> > >> > >>> > >>> > >>>> > >>>> Remove the memory node to fix this. > >>>> > >>>> This behaviour was seen on a i.mx8mp-evk but the > >>>> imx8mp-tqma8mpql-mba8mpxl also has a memory node and includes the > >>>> barebox.dtsi. > >>>> > >>>> Fixes: f083fffe52 ("ARM: dts: i.MX8MP: add DDRC compatibles") > >>>> Signed-off-by: Marco Felsch > >>>> --- > >>>> arch/arm/dts/imx8mp-evk.dts | 2 ++ > >>>> arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts | 2 ++ > >>>> 2 files changed, 4 insertions(+) > >>>> > >>>> diff --git a/arch/arm/dts/imx8mp-evk.dts b/arch/arm/dts/imx8mp-evk.dts > >>>> index 0acc3731d5..c7e1f35d2d 100644 > >>>> --- a/arch/arm/dts/imx8mp-evk.dts > >>>> +++ b/arch/arm/dts/imx8mp-evk.dts > >>>> @@ -30,6 +30,8 @@ > >>>> }; > >>>> }; > >>>> > >>>> +/delete-node/ &{/memory@40000000}; > >>>> + > >>>> ðphy1 { > >>>> reset-assert-us = <15000>; > >>>> reset-deassert-us = <100000>; > >>>> diff --git a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts > >>>> index 6e81f58e27..bf23e40489 100644 > >>>> --- a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts > >>>> +++ b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts > >>>> @@ -24,6 +24,8 @@ > >>>> }; > >>>> }; > >>>> > >>>> +/delete-node/ &{/memory@40000000}; > >>>> + > >>>> &usdhc2 { > >>>> #address-cells = <1>; > >>>> #size-cells = <1>; > >>> > >>> -- > >>> Pengutronix e.K. | | > >>> Steuerwalder Str. 21 | http://www.pengutronix.de/ | > >>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > >>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >>> > >>> > >> > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >