From: Sascha Hauer <sha@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] imx-usb-loader: Don't try to transfer more data than contained in the image
Date: Thu, 16 Mar 2023 10:00:50 +0100 [thread overview]
Message-ID: <20230316090050.GS7446@pengutronix.de> (raw)
In-Reply-To: <20230315183338.78433-1-u.kleine-koenig@pengutronix.de>
On Wed, Mar 15, 2023 at 07:33:38PM +0100, Uwe Kleine-König wrote:
> On platforms that don't have a 2nd stage (in my case i.MX25) it usually
> happens the transfer limit for the first (and only) upload is bigger than
> the actual file length. Then it's the right thing to load the complete
> image (minus its header), but not more.
>
> This fixes a failure to boot via USB on i.MX25 that ends in
>
> dl_command err=-1, last_trans=0
>
> Fixes: 3367ebc55ebe ("scripts: imx-usb-loader: simplify code flow for file size calculations")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> scripts/imx/imx-usb-loader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-03-16 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 18:33 Uwe Kleine-König
2023-03-16 9:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316090050.GS7446@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox