From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] usb: gadget: fastboot: Do not dequeue idle request
Date: Fri, 24 Mar 2023 09:48:07 +0100 [thread overview]
Message-ID: <20230324084807.m445atwiirq477ve@pengutronix.de> (raw)
In-Reply-To: <20230324082748.987672-1-s.hauer@pengutronix.de>
On 23-03-24, Sascha Hauer wrote:
> In fastboot_disable() all endpoints are disabled which will complete
> all outstanding requests with -ESHUTDOWN. fastboot_unbind() is called
> after that, so we do not need to deqeueue any requests there.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> drivers/usb/gadget/function/f_fastboot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_fastboot.c b/drivers/usb/gadget/function/f_fastboot.c
> index 4266b78b40..41450268fc 100644
> --- a/drivers/usb/gadget/function/f_fastboot.c
> +++ b/drivers/usb/gadget/function/f_fastboot.c
> @@ -319,7 +319,6 @@ static void fastboot_unbind(struct usb_configuration *c, struct usb_function *f)
> {
> struct f_fastboot *f_fb = func_to_fastboot(f);
>
> - usb_ep_dequeue(f_fb->out_ep, f_fb->out_req);
> free(f_fb->out_req->buf);
> usb_ep_free_request(f_fb->out_ep, f_fb->out_req);
> f_fb->out_req = NULL;
> --
> 2.30.2
>
>
prev parent reply other threads:[~2023-03-24 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 8:27 Sascha Hauer
2023-03-24 8:48 ` Marco Felsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324084807.m445atwiirq477ve@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox