* [PATCH] usb: gadget: fastboot: Do not dequeue idle request
@ 2023-03-24 8:27 Sascha Hauer
2023-03-24 8:48 ` Marco Felsch
0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2023-03-24 8:27 UTC (permalink / raw)
To: Barebox List; +Cc: Marco Felsch
In fastboot_disable() all endpoints are disabled which will complete
all outstanding requests with -ESHUTDOWN. fastboot_unbind() is called
after that, so we do not need to deqeueue any requests there.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/usb/gadget/function/f_fastboot.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_fastboot.c b/drivers/usb/gadget/function/f_fastboot.c
index 4266b78b40..41450268fc 100644
--- a/drivers/usb/gadget/function/f_fastboot.c
+++ b/drivers/usb/gadget/function/f_fastboot.c
@@ -319,7 +319,6 @@ static void fastboot_unbind(struct usb_configuration *c, struct usb_function *f)
{
struct f_fastboot *f_fb = func_to_fastboot(f);
- usb_ep_dequeue(f_fb->out_ep, f_fb->out_req);
free(f_fb->out_req->buf);
usb_ep_free_request(f_fb->out_ep, f_fb->out_req);
f_fb->out_req = NULL;
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: fastboot: Do not dequeue idle request
2023-03-24 8:27 [PATCH] usb: gadget: fastboot: Do not dequeue idle request Sascha Hauer
@ 2023-03-24 8:48 ` Marco Felsch
0 siblings, 0 replies; 2+ messages in thread
From: Marco Felsch @ 2023-03-24 8:48 UTC (permalink / raw)
To: Sascha Hauer; +Cc: Barebox List
On 23-03-24, Sascha Hauer wrote:
> In fastboot_disable() all endpoints are disabled which will complete
> all outstanding requests with -ESHUTDOWN. fastboot_unbind() is called
> after that, so we do not need to deqeueue any requests there.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> drivers/usb/gadget/function/f_fastboot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_fastboot.c b/drivers/usb/gadget/function/f_fastboot.c
> index 4266b78b40..41450268fc 100644
> --- a/drivers/usb/gadget/function/f_fastboot.c
> +++ b/drivers/usb/gadget/function/f_fastboot.c
> @@ -319,7 +319,6 @@ static void fastboot_unbind(struct usb_configuration *c, struct usb_function *f)
> {
> struct f_fastboot *f_fb = func_to_fastboot(f);
>
> - usb_ep_dequeue(f_fb->out_ep, f_fb->out_req);
> free(f_fb->out_req->buf);
> usb_ep_free_request(f_fb->out_ep, f_fb->out_req);
> f_fb->out_req = NULL;
> --
> 2.30.2
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-24 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 8:27 [PATCH] usb: gadget: fastboot: Do not dequeue idle request Sascha Hauer
2023-03-24 8:48 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox