From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 11 Apr 2023 09:16:55 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pm8FK-00HI71-Oo for lore@lore.pengutronix.de; Tue, 11 Apr 2023 09:16:55 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm8F9-0001gh-As for lore@pengutronix.de; Tue, 11 Apr 2023 09:16:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B3khCo1DO2hwfEIDwNScTlxKOM3KDTAhQG5pvFa9M1I=; b=CzUSxY+dzEalZWOOx7LeIRsO0P yv+7ch0kIy2fIO91AbmxiOwvFLHdQvmKCj4fxexAcS4mjoLlmy48az+UEOwPvAsbtGHlVn/8iDmOG 1s9N8xi+atT4JR1Z+3wEU7S+HIoH7NQ9O5mZ1TDETIvClSFgaFZRbW+RGkbcjiqmWJxePG9+vyoRH W5GnB3jS1gVHbO1AjIaliPC28CbLNnsw1DZGAQAD43YSqLVh1Zh33GEx0MnBDOBp3Uxsvkw3Wt8ho JKRbMbID4x2R5AiQ0NYdl/sAGxV4CziHa21UeC91FXvCBpwNC/dpxjTAoW0BVBVMtlFXA++biPG46 1Td5fx8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pm8DR-00Gg4p-1K; Tue, 11 Apr 2023 07:14:57 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pm8DH-00GfxY-39 for barebox@lists.infradead.org; Tue, 11 Apr 2023 07:14:51 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm8DF-0000sD-AA; Tue, 11 Apr 2023 09:14:45 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pm8DE-00ARvo-Lm; Tue, 11 Apr 2023 09:14:44 +0200 Received: from afa by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pm8DB-006qO0-Pz; Tue, 11 Apr 2023 09:14:41 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Tue, 11 Apr 2023 09:14:33 +0200 Message-Id: <20230411071436.1630752-12-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230411071436.1630752-1-a.fatoum@pengutronix.de> References: <20230411071436.1630752-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_001448_009250_B00CD99E X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master 11/14] Kbuild: export CROSS_PKG_CONFIG X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) CROSS_PKG_CONFIG is referenced in both Kconfig and Makefiles. To be visibile everywhere, its default needs to be exported, but it wasn't. This wasn't noticed, because usual usage was: CROSS_PKG_CONFIG=some-pkg-config make scripts where the shell took care to export the variable. On NixOS, cross pkg-config is actually called ${CROSS_COMPILE}pkg-config and it didn't work out of the box. Fix this. Fixes: 1c1198a3f252 ("scripts: allow building USB loader tools for target as well") Signed-off-by: Ahmad Fatoum --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6f2f4ce74800..3debf5b42799 100644 --- a/Makefile +++ b/Makefile @@ -364,7 +364,7 @@ KCONFIG_CONFIG ?= .config CROSS_PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config -export KCONFIG_CONFIG +export KCONFIG_CONFIG CROSS_PKG_CONFIG # SHELL used by kbuild CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \ -- 2.39.2