From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 11 Apr 2023 13:58:26 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pmCdl-00HVdQ-5D for lore@lore.pengutronix.de; Tue, 11 Apr 2023 13:58:26 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmCdk-0002dt-PR for lore@pengutronix.de; Tue, 11 Apr 2023 13:58:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A2atnpGqWHAS3fQ+oftgYR72rQjT+fK+GENJgfTVIFc=; b=jpXWfzPBs34l6l0iMngdxPhmns gubcsyVnmcmWnJAJiK+FdXFki9+uZC8sjMyPveOPYaSNuhZ624bWFnsVkyMy8RAOurvP4jN9ytyb3 Rl4KDouXnCUGCyJM0MxnTihSEN5vxaoAq03cYCJK45aOQEVMt2bF/0Wgy+PRnqCenQjC/TTwSqgEf feZfAcpXx+5cy5cC9P6qyr4pEHjerN/5hcTddojAMcMSKm7AzmnfxinR4i/Mo5nAOO4XHXPbtdU8x IVJjrKyzpORQFa3wqk0hk7wfJbxLmO69bWvmLXYERjTNzjVKKlQzEk8agHotM9bPp08EDUO7RbxcZ YKV4At1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmCca-00HUIv-37; Tue, 11 Apr 2023 11:57:12 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmCcW-00HUIW-1G for barebox@lists.infradead.org; Tue, 11 Apr 2023 11:57:09 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmCcS-0002TB-5s; Tue, 11 Apr 2023 13:57:04 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pmCcR-0005cY-UD; Tue, 11 Apr 2023 13:57:03 +0200 Date: Tue, 11 Apr 2023 13:57:03 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20230411115703.GD19113@pengutronix.de> References: <20230411071436.1630752-1-a.fatoum@pengutronix.de> <20230411071436.1630752-15-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230411071436.1630752-15-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_045708_433554_A2B5F2DB X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master 14/14] kbuild: remove useless use of /usr/bin/env X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Tue, Apr 11, 2023 at 09:14:36AM +0200, Ahmad Fatoum wrote: > For some reason, NixOS failed to build device trees, because of the use > of `/usr/bin/env echo -e` here. Given that calling /usr/bin/env is > unneeded anyway for echo, let's just drop it and make the NixOS build > problem go away as well. /usr/bin/env was used on purpose here, likely because for example the dash echo builtin does not support the -e option. See https://lore.barebox.org/barebox/20220120091433.GJ7102@pengutronix.de/ Michael suggested to use printf back then. Sascha > > Signed-off-by: Ahmad Fatoum > --- > scripts/Makefile.lib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 4deaa5dfa73c..8f6dcd7430a1 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -372,7 +372,7 @@ $(obj)/%.dtb.z: $(obj)/%.dtb FORCE > dts-frags = $(subst $(quote),,$(CONFIG_EXTERNAL_DTS_FRAGMENTS)) > quiet_cmd_dtc = DTC $@ > # For compatibility between make 4.2 and 4.3 > -cmd_dtc = /usr/bin/env echo -e '$(pound)define $(subst -,_,$(*F))_dts 1\n'$(foreach f,$< $(2),'$(pound)include "$(f)"\n') | \ > +cmd_dtc = echo -e '$(pound)define $(subst -,_,$(*F))_dts 1\n'$(foreach f,$< $(2),'$(pound)include "$(f)"\n') | \ > $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) - ; \ > $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 \ > -i $(srctree)/arch/$(SRCARCH)/dts $(DTC_FLAGS) \ > -- > 2.39.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |