Re: [PATCH v3 0/3] boards: qemu-virt: support passing in FIT public key

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Apr 11, 2023 at 12:00:18PM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> please drop 
> 
>   a9d3244883d7 ("boards: qemu-virt: apply overlay at postcore_initcall level")
>   e664ca8f7c35 ("boards: qemu-virt: compile overlay as such")
>   224b5ef1da4c ("boards: qemu-virt: support passing in FIT public key")
> 
> again. I had been testing with ARM qemu_virt64_defconfig, but now that
> I tested on RISC-V, I notice that non-qemu-virt platforms also execute
> the initcall when they shouldn't and that DTC_CPP_FLAGS wasn't defined
> for overlays leading to broken state there.
> 
> I'll send a revised version, but please drop the current one for now.

Ok, did that.

Sascha

> 
> Thanks,
> Ahmad
> 
> On 13.03.23 15:42, Ahmad Fatoum wrote:
> > FIT public key is usually passed in via board DT. Usual way to use
> > barebox with QEMU Virt however is to use DT supplied by Qemu and apply
> > overlay to it. mkimage doesn't generate overlay DTB though. To make
> > barbebox Qemu Virt behave like other boards, let's define a dummy DT
> > that includes CONFIG_BOOTM_FITIMAGE_PUBKEY, which is merged with the
> > barebox live device tree.
> > 
> > This replaces v2 of the series available in next and fixes the
> > regressions I introduced for deep-probe systems that ensure probe in
> > other devices.
> > 
> > I dropped Jan's Tested-by, because the differences warrant it, but
> > I tested locally that a RSA key was registered as before.
> > 
> > v2 was here:
> > https://lore.barebox.org/barebox/20230210165353.3601175-1-a.fatoum@pengutronix.de/
> > 
> > v2 -> v3:
> >   - drop "support of_ensure_probed for top-level machine device"
> >   - switch from board driver back to initcall
> > 
> > v1 -> v2:
> >   - support of_ensure_probed for top-level machine device
> >   - ensure qemu board driver is probed at postcore
> > 
> > Ahmad Fatoum (3):
> >   boards: qemu-virt: apply overlay at postcore_initcall level
> >   boards: qemu-virt: compile overlay as such
> >   boards: qemu-virt: support passing in FIT public key
> > 
> >  common/boards/qemu-virt/Makefile              |  2 +-
> >  common/boards/qemu-virt/board.c               | 52 +++++++++++--------
> >  common/boards/qemu-virt/fitimage-pubkey.dts   |  7 +++
> >  .../{overlay-of-flash.dts => flash.dtso}      |  0
> >  4 files changed, 38 insertions(+), 23 deletions(-)
> >  create mode 100644 common/boards/qemu-virt/fitimage-pubkey.dts
> >  rename common/boards/qemu-virt/{overlay-of-flash.dts => flash.dtso} (100%)
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |