* [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE
@ 2023-04-20 19:52 Andreas Kemnade
2023-04-21 6:22 ` Andreas Kemnade
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andreas Kemnade @ 2023-04-20 19:52 UTC (permalink / raw)
To: barebox; +Cc: Andreas Kemnade
Fix
include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
include/mach/imx/bbu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/mach/imx/bbu.h b/include/mach/imx/bbu.h
index 451ae15740..50657d9895 100644
--- a/include/mach/imx/bbu.h
+++ b/include/mach/imx/bbu.h
@@ -204,7 +204,7 @@ imx7_bbu_internal_spi_i2c_register_handler(const char *name, char *devicefile,
static inline int
imx8m_bbu_internal_flexspi_nor_register_handler(const char *name, const char *devicefile,
- unsigned long flags);
+ unsigned long flags)
{
return -ENOSYS;
}
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE
2023-04-20 19:52 [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE Andreas Kemnade
@ 2023-04-21 6:22 ` Andreas Kemnade
2023-04-21 6:55 ` Marco Felsch
2023-05-02 11:48 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Kemnade @ 2023-04-21 6:22 UTC (permalink / raw)
To: barebox
On Thu, 20 Apr 2023 21:52:55 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:
> Fix
> include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
should probably have added a fixes:
Fixes: 6e0cb133be ("ARM: i.MX: bbu: add FlexSPI update handler")
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE
2023-04-20 19:52 [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE Andreas Kemnade
2023-04-21 6:22 ` Andreas Kemnade
@ 2023-04-21 6:55 ` Marco Felsch
2023-05-02 11:48 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Marco Felsch @ 2023-04-21 6:55 UTC (permalink / raw)
To: Andreas Kemnade; +Cc: barebox
Hi Andreas,
On 23-04-20, Andreas Kemnade wrote:
> Fix
> include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token
argh.. thanks a lot.
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> include/mach/imx/bbu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/mach/imx/bbu.h b/include/mach/imx/bbu.h
> index 451ae15740..50657d9895 100644
> --- a/include/mach/imx/bbu.h
> +++ b/include/mach/imx/bbu.h
> @@ -204,7 +204,7 @@ imx7_bbu_internal_spi_i2c_register_handler(const char *name, char *devicefile,
>
> static inline int
> imx8m_bbu_internal_flexspi_nor_register_handler(const char *name, const char *devicefile,
> - unsigned long flags);
> + unsigned long flags)
> {
> return -ENOSYS;
> }
> --
> 2.39.2
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE
2023-04-20 19:52 [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE Andreas Kemnade
2023-04-21 6:22 ` Andreas Kemnade
2023-04-21 6:55 ` Marco Felsch
@ 2023-05-02 11:48 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2023-05-02 11:48 UTC (permalink / raw)
To: Andreas Kemnade; +Cc: barebox
On Thu, Apr 20, 2023 at 09:52:55PM +0200, Andreas Kemnade wrote:
> Fix
> include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> include/mach/imx/bbu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/include/mach/imx/bbu.h b/include/mach/imx/bbu.h
> index 451ae15740..50657d9895 100644
> --- a/include/mach/imx/bbu.h
> +++ b/include/mach/imx/bbu.h
> @@ -204,7 +204,7 @@ imx7_bbu_internal_spi_i2c_register_handler(const char *name, char *devicefile,
>
> static inline int
> imx8m_bbu_internal_flexspi_nor_register_handler(const char *name, const char *devicefile,
> - unsigned long flags);
> + unsigned long flags)
> {
> return -ENOSYS;
> }
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-02 11:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-20 19:52 [PATCH] ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE Andreas Kemnade
2023-04-21 6:22 ` Andreas Kemnade
2023-04-21 6:55 ` Marco Felsch
2023-05-02 11:48 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox