From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 05/10] MAKEALL: Do not trap
Date: Tue, 2 May 2023 09:39:20 +0200 [thread overview]
Message-ID: <20230502073925.266116-6-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20230502073925.266116-1-s.hauer@pengutronix.de>
Just print the compile statistics at the end. There's no need to print
them when MAKEALL gets interrupted, so just simplify the code by
removing trapping signals.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
MAKEALL | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/MAKEALL b/MAKEALL
index c1048a21e2..4dcfa4138c 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -2,10 +2,6 @@
#
# SPDX-License-Identifier: GPL-2.0-only
-# Print statistics when we exit
-trap exit 1 2 3 15
-trap stats 0
-
# Keep track of the number of builds and errors
nb_errors=0
errors_list=""
@@ -16,12 +12,9 @@ time_start=$(date +%s)
filename=$(basename $0)
-is_print_stats=1
-
#-----------------------------------------------------------------------
usage() {
- is_print_stats=0
echo "Usage: ${filename} [OPTION]..."
echo "Barebox MAKEALL tools."
echo ""
@@ -61,8 +54,6 @@ usage() {
}
stats() {
- [ ${is_print_stats} -lt 1 ] && return
-
echo ""
echo "--------------------- SUMMARY ----------------------------"
echo "defconfigs compiled: ${nb_defconfigs}"
@@ -280,4 +271,7 @@ then
else
do_build_target ${ARCH} $1
fi
+
+stats
+
exit $nb_errors
--
2.39.2
next prev parent reply other threads:[~2023-05-02 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 7:39 [PATCH 00/10] MAKEALL updates Sascha Hauer
2023-05-02 7:39 ` [PATCH 01/10] MAKEALL: Configure before setting up CROSS_COMPILE Sascha Hauer
2023-05-02 7:39 ` [PATCH 02/10] MAKEALL: Select arm64 toolchain for 64bit ARM configs Sascha Hauer
2023-05-02 7:39 ` [PATCH 03/10] MAKEALL: order configs alphabetically Sascha Hauer
2023-05-02 7:39 ` [PATCH 04/10] MAKEALL: Do not print sizes Sascha Hauer
2023-05-02 7:39 ` Sascha Hauer [this message]
2023-05-02 7:39 ` [PATCH 06/10] MAKEALL: fix printing number of compiled configs Sascha Hauer
2023-05-02 7:39 ` [PATCH 07/10] MAKEALL: support Kconfig fragments Sascha Hauer
2023-05-02 7:39 ` [PATCH 08/10] MAKEALL: rename variables Sascha Hauer
2023-05-02 7:39 ` [PATCH 09/10] MAKEALL: separate errors and warnings Sascha Hauer
2023-05-02 7:39 ` [PATCH 10/10] MAKEALL: allow multiple defconfigs as arguments Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502073925.266116-6-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox