Re: [PATCH v1 4/4] arm: dts: stm32mp151-prtt1l: Configure USB gadget FIFOs for multiple gadgets support

[Oleksij Rempel <o.rempel@pengutronix.de>]

Hello Ahmad,

On Wed, May 03, 2023 at 12:25:03PM +0200, Ahmad Fatoum wrote:
> Hello Oleksij,
> 
> On 03.05.23 12:19, Oleksij Rempel wrote:
> > This patch configures the USB gadget FIFOs of PRTT1L boards to support
> > multiple gadgets at the same time. The configuration was tested with the
> > "usbgadget -S '/dev/mmc1(mmc1)' -s -A '' -b" command.
> 
> What's the downside on configuring the FIFO this way globally
> in stm32mp151.dtsi? Should the same be done for Linux?

I do not know. It seems to be the use-case and SoC specific. Probably doing
this type of configuration in the devicetree is not the best idea at
all, but currently it is only way to do it in kernel, so let's do it in
barebox too.

> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  arch/arm/dts/stm32mp151-prtt1l.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/dts/stm32mp151-prtt1l.dtsi b/arch/arm/dts/stm32mp151-prtt1l.dtsi
> > index 98a9c20d6d..fecd068fc0 100644
> > --- a/arch/arm/dts/stm32mp151-prtt1l.dtsi
> > +++ b/arch/arm/dts/stm32mp151-prtt1l.dtsi
> > @@ -56,6 +56,7 @@
> >  	phys = <&usbphyc_port1 0>;
> >  	phy-names = "usb2-phy";
> >  	status = "okay";
> > +	g-tx-fifo-size = <128 128 128 16>;
> >  };
> >  
> >  &usbphyc {
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |