From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 03 May 2023 14:28:13 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1puBag-0038Kw-C0 for lore@lore.pengutronix.de; Wed, 03 May 2023 14:28:13 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puBae-0006qo-Av for lore@pengutronix.de; Wed, 03 May 2023 14:28:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=FuRtp4ZXT42HrVOxDjz50byLxJ0LNEFHBa04nMBF6so=; b=0MPjhVRzjqhhS5h3LW1F+5nk69 vv3Fy2jcHQ6uxTCfCOXvdApIxxCLz3Gbr42GMy7c+VXfJ9JQ/7KXti46jQC45len6/JbYqNDL3IK7 GnbTuXFozKQQbZtWE3R4IifnVZ1PWVqSLT1KN91CflqdOMfkJDzoxt3QI5T2j7qnJLjZrKRV4yUOK rZVanY5/oqZnu0OS9h3HT7Mzf3NZeHfPau32kwRRMmejDsKgYaptATpoVmZcvdLvm0viBhxvs3WbX ARGuIb1n9WrSEOmRLQ9mEIIqCxlmqCQf+wcE7AkxPrXscfQY+gwot/+rpmRiggoQcX9XvArHKwwcL MlqmRX5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puBZi-004YSs-0H; Wed, 03 May 2023 12:27:14 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puBZf-004YSC-0I for barebox@lists.infradead.org; Wed, 03 May 2023 12:27:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puBZd-0006lG-R7; Wed, 03 May 2023 14:27:09 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1puBZd-000pC9-6M; Wed, 03 May 2023 14:27:09 +0200 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1puBZc-005X5m-Fy; Wed, 03 May 2023 14:27:08 +0200 From: Sascha Hauer To: Barebox List Date: Wed, 3 May 2023 14:27:08 +0200 Message-Id: <20230503122708.1318713-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230503_052711_131094_F604D199 X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] pcie-designware: Fix dev_get_resource_by_name error check X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) dev_get_resource_by_name() returns an error pointer, fix the check accordingly. Signed-off-by: Sascha Hauer --- drivers/pci/pcie-designware-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pcie-designware-host.c b/drivers/pci/pcie-designware-host.c index c143de4eef..b34fc482ed 100644 --- a/drivers/pci/pcie-designware-host.c +++ b/drivers/pci/pcie-designware-host.c @@ -87,7 +87,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp) ns = of_n_size_cells(np); cfg_res = dev_get_resource_by_name(dev, IORESOURCE_MEM, "config"); - if (cfg_res) { + if (!IS_ERR(cfg_res)) { pp->cfg0_size = resource_size(cfg_res) >> 1; pp->cfg1_size = resource_size(cfg_res) >> 1; pp->cfg0_base = cfg_res->start; -- 2.39.2