mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Johannes Zink <j.zink@pengutronix.de>
To: barebox@lists.infradead.org
Cc: patchwork-jzi@pengutronix.de
Subject: [PATCH v2 0/3] Add displaying a version number in imx-usb-loader
Date: Fri,  5 May 2023 17:52:45 +0200	[thread overview]
Message-ID: <20230505155248.2261867-1-j.zink@pengutronix.de> (raw)

This series adds displaying a version number in imx-usb-loader for
easier debugging.

The first two patches add minor cleanup, while the third actually adds
the code for displaying the version number.

The result will look like
$./imx-usb-loader --version
./imx-usb-loader 2023.04.0-00210-g057705fb211a-dirty

Happy hacking
Johannes

Changelog:
  v1 -> v2: worked in Ahmad's review findings. Thanks for reviewing my
            patches!
            - do not rely on autogenerated headers to keep tool buildable
	      outside of KBuild environment
	    - remove double exit when displaying version number
	    - fixed errornous commit subject
	    - added comment in commit message why removing the exit()
	      call in a function is ok, even when not explicitely adding
	      it to all call sites


Johannes Zink (3):
  imx-usb-loader: exit with success when displaying help on purpose
  imx-usb-loader: use proper return code macros
  imx-usb-loader: add commandline option for displaying version number

 scripts/imx/Makefile         |  2 +-
 scripts/imx/imx-usb-loader.c | 30 +++++++++++++++++++++++++-----
 2 files changed, 26 insertions(+), 6 deletions(-)

-- 
2.39.2




             reply	other threads:[~2023-05-05 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 15:52 Johannes Zink [this message]
2023-05-05 15:52 ` [PATCH v2 1/3] imx-usb-loader: exit with success when displaying help on purpose Johannes Zink
2023-05-05 15:52 ` [PATCH v2 2/3] imx-usb-loader: use proper return code macros Johannes Zink
2023-05-05 15:52 ` [PATCH v2 3/3] imx-usb-loader: add commandline option for displaying version number Johannes Zink
2023-05-09  7:22 ` [PATCH v2 0/3] Add displaying a version number in imx-usb-loader Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230505155248.2261867-1-j.zink@pengutronix.de \
    --to=j.zink@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=patchwork-jzi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox