From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 05 May 2023 17:54:34 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1puxlT-006IKe-6L for lore@lore.pengutronix.de; Fri, 05 May 2023 17:54:34 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puxlR-0002UN-DP for lore@pengutronix.de; Fri, 05 May 2023 17:54:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Knk29BG6YVEK3n2oparqbC9fkUg1f0AK7yNqzExtpi0=; b=Ls4nleppQRbdYvWjbMbjG1lHZE vqotc/jZm4SZeIcfLLQ1CDfyiwL143QR2cnQRLuqL7MYFn9WuLS28wvdNdv2U1XLQZftYzXDpItDZ no4FvdaKlUngr4zy8NC9nRZvjoihay+FS5GttWCBlICJbWDr43xlc+cSdzgN30Z+J/uciuo37DVyC d1HWB8puUnDrTFzljcWpqKFj5dnvIUpij/vIY0jqAAl07cTo8KvBV8LoA60iCWQW9eRnxIA1El84j qWsXxhdhKAq67UpoE/3fMsW0lu/FUxYiqMTJfd+JfJkQwYBWozjR29SgPqp6gAjWTq5+FGmF3sbu9 yHE1kKTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puxk7-00BFK3-2O; Fri, 05 May 2023 15:53:11 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puxk0-00BFHe-28 for barebox@lists.infradead.org; Fri, 05 May 2023 15:53:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puxjw-0002Hy-Ng; Fri, 05 May 2023 17:53:00 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1puxjw-001KXC-2u; Fri, 05 May 2023 17:53:00 +0200 Received: from jzi by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1puxju-009Vyd-Ty; Fri, 05 May 2023 17:52:59 +0200 From: Johannes Zink To: barebox@lists.infradead.org Cc: patchwork-jzi@pengutronix.de Date: Fri, 5 May 2023 17:52:45 +0200 Message-Id: <20230505155248.2261867-1-j.zink@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_085304_702889_067008CD X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 0/3] Add displaying a version number in imx-usb-loader X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) This series adds displaying a version number in imx-usb-loader for easier debugging. The first two patches add minor cleanup, while the third actually adds the code for displaying the version number. The result will look like $./imx-usb-loader --version ./imx-usb-loader 2023.04.0-00210-g057705fb211a-dirty Happy hacking Johannes Changelog: v1 -> v2: worked in Ahmad's review findings. Thanks for reviewing my patches! - do not rely on autogenerated headers to keep tool buildable outside of KBuild environment - remove double exit when displaying version number - fixed errornous commit subject - added comment in commit message why removing the exit() call in a function is ok, even when not explicitely adding it to all call sites Johannes Zink (3): imx-usb-loader: exit with success when displaying help on purpose imx-usb-loader: use proper return code macros imx-usb-loader: add commandline option for displaying version number scripts/imx/Makefile | 2 +- scripts/imx/imx-usb-loader.c | 30 +++++++++++++++++++++++++----- 2 files changed, 26 insertions(+), 6 deletions(-) -- 2.39.2