Re: [PATCH v2 0/3] Add displaying a version number in imx-usb-loader

[Sascha Hauer <sha@pengutronix.de>]

On Fri, May 05, 2023 at 05:52:45PM +0200, Johannes Zink wrote:
> This series adds displaying a version number in imx-usb-loader for
> easier debugging.
> 
> The first two patches add minor cleanup, while the third actually adds
> the code for displaying the version number.
> 
> The result will look like
> $./imx-usb-loader --version
> ./imx-usb-loader 2023.04.0-00210-g057705fb211a-dirty
> 
> Happy hacking
> Johannes
> 
> Changelog:
>   v1 -> v2: worked in Ahmad's review findings. Thanks for reviewing my
>             patches!
>             - do not rely on autogenerated headers to keep tool buildable
> 	      outside of KBuild environment
> 	    - remove double exit when displaying version number
> 	    - fixed errornous commit subject
> 	    - added comment in commit message why removing the exit()
> 	      call in a function is ok, even when not explicitely adding
> 	      it to all call sites
> 
> 
> Johannes Zink (3):
>   imx-usb-loader: exit with success when displaying help on purpose
>   imx-usb-loader: use proper return code macros
>   imx-usb-loader: add commandline option for displaying version number

Applied, thanks

Sascha

> 
>  scripts/imx/Makefile         |  2 +-
>  scripts/imx/imx-usb-loader.c | 30 +++++++++++++++++++++++++-----
>  2 files changed, 26 insertions(+), 6 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |