From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mfd: syscon: Remove unused helper syscon_base_lookup_by_pdevname
Date: Tue, 9 May 2023 09:24:13 +0200 [thread overview]
Message-ID: <20230509072413.GD29365@pengutronix.de> (raw)
In-Reply-To: <20230505061245.463528-1-eagle.alexander923@gmail.com>
On Fri, May 05, 2023 at 09:12:44AM +0300, Alexander Shiyan wrote:
> Nobody uses the exported helper syscon_base_lookup_by_pdevname,
> to lookup a syscon by device name. Let us remove it.
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> drivers/mfd/syscon.c | 15 ---------------
> include/mfd/syscon.h | 6 ------
> 2 files changed, 21 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 5d1fed4aee..16d78de2af 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -142,21 +142,6 @@ static void __iomem *syscon_node_to_base(struct device_node *np)
> return syscon->base;
> }
>
> -void __iomem *syscon_base_lookup_by_pdevname(const char *s)
> -{
> - struct syscon *syscon;
> - struct device *dev;
> -
> - for_each_device(dev) {
> - if (!strcmp(dev_name(dev), s)) {
> - syscon = dev->priv;
> - return syscon->base;
> - }
> - }
> -
> - return ERR_PTR(-ENODEV);
> -}
> -
> void __iomem *syscon_base_lookup_by_phandle(struct device_node *np,
> const char *property)
> {
> diff --git a/include/mfd/syscon.h b/include/mfd/syscon.h
> index b47aa1e160..3ccfd7fb5b 100644
> --- a/include/mfd/syscon.h
> +++ b/include/mfd/syscon.h
> @@ -17,7 +17,6 @@
> #include <regmap.h>
>
> #ifdef CONFIG_MFD_SYSCON
> -void __iomem *syscon_base_lookup_by_pdevname(const char *s);
> void __iomem *syscon_base_lookup_by_phandle
> (struct device_node *np, const char *property);
> struct regmap *syscon_node_to_regmap(struct device_node *np);
> @@ -27,11 +26,6 @@ extern struct regmap *syscon_regmap_lookup_by_phandle(
> struct device_node *np,
> const char *property);
> #else
> -static inline void __iomem *syscon_base_lookup_by_pdevname(const char *s)
> -{
> - return ERR_PTR(-ENOSYS);
> -}
> -
> static inline void __iomem *syscon_base_lookup_by_phandle
> (struct device_node *np, const char *property)
> {
> --
> 2.39.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-05-09 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 6:12 Alexander Shiyan
2023-05-09 7:24 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509072413.GD29365@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox