mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Christian Melki <christian.melki@t2data.com>,
	jbe@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [RFT PATCH 2/2] mtd: cfi-flash: call ctrlc() during CFI reads
Date: Mon, 22 May 2023 07:25:26 +0200	[thread overview]
Message-ID: <20230522052526.1038966-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20230522052526.1038966-1-a.fatoum@pengutronix.de>

Memory mapped flash access can be quite slow on older processors. For
writing and erasing, we already call resched() indirectly to feed the
watchdog, so let's do this when reading as well. This fixes an issue
of short running watchdogs triggering on PowerPC, because kernel boot
takes too long.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mtd/nor/cfi_flash.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nor/cfi_flash.c b/drivers/mtd/nor/cfi_flash.c
index f1555a72a42e..10542c710118 100644
--- a/drivers/mtd/nor/cfi_flash.c
+++ b/drivers/mtd/nor/cfi_flash.c
@@ -25,7 +25,9 @@
 #include <io.h>
 #include <errno.h>
 #include <progress.h>
+#include <string.h>
 #include <linux/err.h>
+#include <linux/sizes.h>
 #include <asm/unaligned.h>
 #include <linux/mtd/concat.h>
 #include "cfi_flash.h"
@@ -891,10 +893,16 @@ static int cfi_mtd_read(struct mtd_info *mtd, loff_t from, size_t len,
 		size_t *retlen, u8 *buf)
 {
 	struct flash_info *info = container_of(mtd, struct flash_info, mtd);
+	const void *src = info->base + from;
+	size_t i;
+
+	for (i = 0; i < len; i = size_add(i, SZ_1M)) {
+		buf = mempcpy(buf, src + i, min_t(size_t, len, SZ_1M));
+		if (ctrlc())
+			return -EINTR;
+	}
 
-	memcpy(buf, info->base + from, len);
 	*retlen = len;
-
 	return 0;
 }
 
-- 
2.39.2




  reply	other threads:[~2023-05-22  5:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  5:25 [RFT PATCH 1/2] include: <linux/overflow.h>: sync with kernel Ahmad Fatoum
2023-05-22  5:25 ` Ahmad Fatoum [this message]
2023-05-22  8:38   ` [RFT PATCH 2/2] mtd: cfi-flash: call ctrlc() during CFI reads Ahmad Fatoum
2023-05-22  9:21     ` Christian Melki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522052526.1038966-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=christian.melki@t2data.com \
    --cc=jbe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox